Sign upLogin

grafana/grafana-polystat-panel

View on GitHub
Star
src/data/processor.ts

Summary

Maintainability
D
2 days
Test Coverage

Function ApplyGlobalFormatting has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Wontfix

export const ApplyGlobalFormatting = (
  data: PolystatModel[],
  fieldConfig: FieldConfigSource<any>,
  globalUnitFormat: string,
  globalDecimals: number,
Severity: Minor
Found in src/data/processor.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File processor.ts has 317 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { InsertTime } from './deframer';
import {
  Field,
  FieldType,
  reduceField,
Severity: Minor
Found in src/data/processor.ts - About 3 hrs to fix

    Function ProcessDataFrames has 28 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      compositesEnabled: boolean,
  composites: CompositeItemType[],
  overrides: OverrideItemType[],
  data: PanelData,
  replaceVariables: InterpolateFunction,
    Severity: Major
    Found in src/data/processor.ts - About 3 hrs to fix

      Function FilterByGlobalDisplayMode has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      const FilterByGlobalDisplayMode = (data: any, globalDisplayMode: string): PolystatModel[] => {
  const filteredMetrics: number[] = [];
  const compositeMetrics: PolystatModel[] = [];
  if (globalDisplayMode !== 'all') {
    const dataLen = data.length;
      Severity: Minor
      Found in src/data/processor.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ApplyGlobalRegexPattern has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      export const ApplyGlobalRegexPattern = (data: PolystatModel[], regexPattern: string): PolystatModel[] => {
  for (let i = 0; i < data.length; i++) {
    if (regexPattern !== '') {
      const regexVal = stringToJsRegex(regexPattern);
      if (data[i].name && regexVal.test(data[i].name.toString())) {
      Severity: Minor
      Found in src/data/processor.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function DataFrameToPolystat has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      export const DataFrameToPolystat = (frame: DataFrame, globalOperator: string): PolystatModel[] => {

  const valueFields: Field[] = [];
  let newestTimestamp = 0;
      Severity: Minor
      Found in src/data/processor.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  if (value) {
              extractedTxt += extractedTxt.length > 0 ? ' ' + value.toString() : value.toString();
            }
      Severity: Major
      Found in src/data/processor.ts - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if (formatted.suffix) {
            data[index].valueFormatted += ` ${formatted.suffix}`;
          }
        Severity: Major
        Found in src/data/processor.ts - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    if (valueRounded !== null) {
            data[index].valueRounded = valueRounded;
          }
          Severity: Major
          Found in src/data/processor.ts - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                      if (formatted.prefix) {
            data[index].valueFormatted = `{$formatted.prefix} ${data[index].valueFormatted}`;
          }
            Severity: Major
            Found in src/data/processor.ts - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Wontfix

                        if (globalShowTimestampEnabled) {
            data[index].timestampFormatted = TimeFormatter(timeZone, data[index].timestamp, globalShowTimestampFormat);
            data[index].showTimestamp = true;
          }
              Severity: Major
              Found in src/data/processor.ts - About 45 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Wontfix

                          if (globalShowTimestampEnabled) {
            data[index].timestampFormatted = TimeFormatter(timeZone, data[index].timestamp, globalShowTimestampFormat);
            data[index].showTimestamp = true;
          }
                Severity: Minor
                Found in src/data/processor.ts and 1 other location - About 40 mins to fix
                src/data/processor.ts on lines 233..236

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Wontfix

                        if (globalShowTimestampEnabled) {
          data[index].timestampFormatted = TimeFormatter(timeZone, data[index].timestamp, globalShowTimestampFormat);
          data[index].showTimestamp = true;
        }
                Severity: Minor
                Found in src/data/processor.ts and 1 other location - About 40 mins to fix
                src/data/processor.ts on lines 259..262

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status