Sign upLogin

granthenke/scurator

View on GitHub
Star
src/main/scala/org/scurator/SCuratorClient.scala

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      val (watchOpt, watcher) = request.watch match {
        case false => (statOpt, None)
        case true =>
          val w = Some(new Watcher())
          (statOpt.usingWatcher(w.get), w)
Severity: Minor
Found in src/main/scala/org/scurator/SCuratorClient.scala and 2 other locations - About 40 mins to fix
src/main/scala/org/scurator/SCuratorClient.scala on lines 138..143
src/main/scala/org/scurator/SCuratorClient.scala on lines 184..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      val (watchOpt, watcher) = request.watch match {
        case false => (builder, None)
        case true =>
          val w = Some(new Watcher())
          (builder.usingWatcher(w.get), w)
Severity: Minor
Found in src/main/scala/org/scurator/SCuratorClient.scala and 2 other locations - About 40 mins to fix
src/main/scala/org/scurator/SCuratorClient.scala on lines 184..189
src/main/scala/org/scurator/SCuratorClient.scala on lines 212..217

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      val stat = request.data match {
        case None => blocking { versionOpt.forPath(request.path, null) } // scalastyle:ignore
        case Some(d) => blocking { versionOpt.forPath(request.path, d) }
      }
Severity: Minor
Found in src/main/scala/org/scurator/SCuratorClient.scala and 1 other location - About 40 mins to fix
src/main/scala/org/scurator/SCuratorClient.scala on lines 98..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      val path = request.data match {
        case None => blocking { aclOpt.forPath(request.path, null) } // scalastyle:ignore
        case Some(d) => blocking { aclOpt.forPath(request.path, d) }
      }
Severity: Minor
Found in src/main/scala/org/scurator/SCuratorClient.scala and 1 other location - About 40 mins to fix
src/main/scala/org/scurator/SCuratorClient.scala on lines 258..261

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      val (watchOpt, watcher) = request.watch match {
        case false => (statOpt, None)
        case true =>
          val w = Some(new Watcher())
          (statOpt.usingWatcher(w.get), w)
Severity: Minor
Found in src/main/scala/org/scurator/SCuratorClient.scala and 2 other locations - About 40 mins to fix
src/main/scala/org/scurator/SCuratorClient.scala on lines 138..143
src/main/scala/org/scurator/SCuratorClient.scala on lines 212..217

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    exists(ExistsRequest(request.path)).map { response =>
      response.stat.map { s =>
        StatResponse(request.path, stat = s)
      }.getOrElse(throw new NoNodeException(request.path))
    }
Severity: Minor
Found in src/main/scala/org/scurator/SCuratorClient.scala and 1 other location - About 30 mins to fix
src/main/scala/org/scurator/SCuratorClient.scala on lines 287..291

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    exists(ExistsRequest(request.path, watch = true)).map { response =>
      response.watch.map { w =>
        WatchResponse(request.path, watch = w)
      }.getOrElse(throw new NoNodeException(request.path))
    }
Severity: Minor
Found in src/main/scala/org/scurator/SCuratorClient.scala and 1 other location - About 30 mins to fix
src/main/scala/org/scurator/SCuratorClient.scala on lines 273..277

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid wildcard imports
Open

import scala.collection.JavaConverters._
Severity: Major
Found in src/main/scala/org/scurator/SCuratorClient.scala by scalastyle

Imports should be grouped together
Open

    import scala.language.implicitConversions
Severity: Major
Found in src/main/scala/org/scurator/SCuratorClient.scala by scalastyle

Avoid wildcard imports
Open

import org.scurator.components._
Severity: Major
Found in src/main/scala/org/scurator/SCuratorClient.scala by scalastyle

There are no issues that match your filters.

Category
Status