graylog-labs/gelf-rb

View on GitHub

Showing 8 of 8 total issues

Class Notifier has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Notifier
    # Maximum number of GELF chunks as per GELF spec
    MAX_CHUNKS = 128
    MAX_CHUNK_SIZE_WAN = 1420
    MAX_CHUNK_SIZE_LAN = 8154
Severity: Minor
Found in lib/gelf/notifier.rb - About 2 hrs to fix

    Method add has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def add(level, message = nil, progname = nil, &block)
          progname ||= default_options['facility']
          message ||= block.call unless block.nil?
    
          if message.nil?
    Severity: Minor
    Found in lib/gelf/logger.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ssl_cert_store has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def ssl_cert_store
            OpenSSL::X509::Store.new.tap do |store|
              unless @tls_options['no_default_ca']
                store.set_default_paths
              end
    Severity: Minor
    Found in lib/gelf/transport/tcp_tls.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method notify_with_level! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def notify_with_level!(message_level, *args)
          return unless @enabled
          hash = extract_hash(*args)
          hash['level'] = message_level unless message_level.nil?
          if hash['level'] >= level
    Severity: Minor
    Found in lib/gelf/notifier.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method connect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def connect(host, port)
            plain_socket = super(host, port)
            start_tls(plain_socket)
          rescue OpenSSL::SSL::SSLError
            plain_socket.close unless plain_socket.closed?
    Severity: Minor
    Found in lib/gelf/transport/tcp_tls.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method write_socket has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def write_socket(socket, message)
            super(socket, message)
          rescue OpenSSL::SSL::SSLError
            socket.close unless socket.closed?
            raise unless rescue_ssl_errors
    Severity: Minor
    Found in lib/gelf/transport/tcp_tls.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method extract_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def extract_hash(object = nil, args = {})
          primary_data = if object.respond_to?(:to_hash)
                           object.to_hash
                         elsif object.is_a?(Exception)
                           args['level'] ||= GELF::ERROR
    Severity: Minor
    Found in lib/gelf/notifier.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method send has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def send(message)
            return if @addresses.empty?
            loop do
              connected = @sockets.reject(&:closed?)
              reconnect_all if connected.empty?
    Severity: Minor
    Found in lib/gelf/transport/tcp.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language