Sign upLogin

greencommons/commons

View on GitHub
Star

Showing 40 of 40 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  propTypes: {
    id: React.PropTypes.number,
    type: React.PropTypes.string,
    name: React.PropTypes.string,
    loader_image: React.PropTypes.string,
Severity: Major
Found in app/assets/javascripts/components/add_to_list/add_to_list_button.js.jsx and 1 other location - About 5 hrs to fix
app/assets/javascripts/components/add_to_list/add_to_list_modal.js.jsx on lines 2..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  propTypes: {
    id: React.PropTypes.number,
    type: React.PropTypes.string,
    name: React.PropTypes.string,
    loaderImage: React.PropTypes.string,
Severity: Major
Found in app/assets/javascripts/components/add_to_list/add_to_list_modal.js.jsx and 1 other location - About 5 hrs to fix
app/assets/javascripts/components/add_to_list/add_to_list_button.js.jsx on lines 2..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        <div className="form-box__title">
          <div className="row">
            <div className="col-xs-10">
              <h1>Add "{this.props.name}" to list</h1>
            </div>
Severity: Major
Found in app/assets/javascripts/components/add_to_list/add_to_list_unauthorized.js.jsx and 2 other locations - About 5 hrs to fix
app/assets/javascripts/components/add_to_list/add_to_list_form.js.jsx on lines 57..68
app/assets/javascripts/components/add_to_list/add_to_list_loading.js.jsx on lines 11..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        <div className="form-box__title">
          <div className="row">
            <div className="col-xs-10">
              <h1>Add "{this.props.name}" to list</h1>
            </div>
Severity: Major
Found in app/assets/javascripts/components/add_to_list/add_to_list_form.js.jsx and 2 other locations - About 5 hrs to fix
app/assets/javascripts/components/add_to_list/add_to_list_loading.js.jsx on lines 11..22
app/assets/javascripts/components/add_to_list/add_to_list_unauthorized.js.jsx on lines 10..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        <div className="form-box__title">
          <div className="row">
            <div className="col-xs-10">
              <h1>Add "{this.props.name}" to list</h1>
            </div>
Severity: Major
Found in app/assets/javascripts/components/add_to_list/add_to_list_loading.js.jsx and 2 other locations - About 5 hrs to fix
app/assets/javascripts/components/add_to_list/add_to_list_form.js.jsx on lines 57..68
app/assets/javascripts/components/add_to_list/add_to_list_unauthorized.js.jsx on lines 10..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function initFilters has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var initFilters = function() {
    var searchFilterCheckboxes = $('[data-filter-checkbox]');
    var daterange = $('input[name="daterange"]');
    var searchForm = $('form.search-remote-form');
    var loadPanel = $('#ajax-loader__panel');
Severity: Major
Found in app/assets/javascripts/filters.js - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      propTypes: {
    name: React.PropTypes.string,
    id: React.PropTypes.string,
    autocompletePath: React.PropTypes.string,
    handler: React.PropTypes.func,
    Severity: Major
    Found in app/assets/javascripts/components/autocomplete/autocomplete_select.js.jsx and 1 other location - About 2 hrs to fix
    app/assets/javascripts/components/autocomplete/autocomplete_form.js.jsx on lines 2..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      propTypes: {
    name: React.PropTypes.string,
    action: React.PropTypes.string,
    autocomplete_url: React.PropTypes.string,
    field: React.PropTypes.string,
    Severity: Major
    Found in app/assets/javascripts/components/autocomplete/autocomplete_form.js.jsx and 1 other location - About 2 hrs to fix
    app/assets/javascripts/components/autocomplete/autocomplete_select.js.jsx on lines 2..9

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function render has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render: function() {
    var icon = '';
    var content = '';

    if (this.props.json.status === 'ok') {
    Severity: Major
    Found in app/assets/javascripts/components/add_to_list/add_to_list_confirmation.js.jsx - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          fetch(this.props.action, {
      method: 'POST',
      credentials: "same-origin",
      headers: { 'X-CSRF-Token': this.props.authenticityToken },
      body: form
      Severity: Major
      Found in app/assets/javascripts/components/add_to_list/add_to_list_form.js.jsx and 1 other location - About 2 hrs to fix
      app/assets/javascripts/components/tags.jsx on lines 26..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            fetch(this.props.submit_url, {
        method: 'POST',
        credentials: "same-origin",
        headers: { 'X-CSRF-Token': this.props.authenticity_token },
        body: form
      Severity: Major
      Found in app/assets/javascripts/components/tags.jsx and 1 other location - About 2 hrs to fix
      app/assets/javascripts/components/add_to_list/add_to_list_form.js.jsx on lines 42..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function render has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        render: function() {
    var content = "";

    switch(this.state.step) {
      case 'unauthorized':
      Severity: Major
      Found in app/assets/javascripts/components/add_to_list/add_to_list_modal.js.jsx - About 2 hrs to fix

        Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          render: function() {
    return (
      <div>
        <div className="form-box__title">
          <div className="row">
        Severity: Minor
        Found in app/assets/javascripts/components/add_to_list/add_to_list_form.js.jsx - About 1 hr to fix

          Method build_current_url has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

                def build_current_url
        return @current_url unless @params.any?

        base = @current_url.split('?')[0]
          Severity: Minor
          Found in lib/yumi/presenters/root_links.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function componentDidMount has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            componentDidMount: function() {
    var _this = this;
    var select = null;

    if (this.props.autocompletePath) {
          Severity: Minor
          Found in app/assets/javascripts/components/autocomplete/autocomplete_select.js.jsx - About 1 hr to fix

            Method set_published_at has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def set_published_at
      if respond_to?(:published_at) && !published_at
        if defined?(metadata) && metadata && metadata['date']
          begin
            self.published_at = Date.parse(metadata['date'])
            Severity: Minor
            Found in app/models/concerns/indexable.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              propTypes: {
    authenticity_token: React.PropTypes.string,
    submit_url: React.PropTypes.string,
    tags: React.PropTypes.array,
    can_create: React.PropTypes.bool
            Severity: Major
            Found in app/assets/javascripts/components/tags.jsx and 1 other location - About 1 hr to fix
            app/assets/javascripts/components/autocomplete/autocomplete_suggestions.js.jsx on lines 2..7

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              propTypes: {
    url: React.PropTypes.string,
    query: React.PropTypes.string,
    loadingHandler: React.PropTypes.func,
    resultHandler: React.PropTypes.func
            Severity: Major
            Found in app/assets/javascripts/components/autocomplete/autocomplete_suggestions.js.jsx and 1 other location - About 1 hr to fix
            app/assets/javascripts/components/tags.jsx on lines 2..7

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def create
    if policy(list).update?
      if valid_type? && item
        list_item.list = list
        list_item.item = item
            Severity: Minor
            Found in app/controllers/list_items_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      <button id="add_tag_button" name="button" type="submit" className="form-control btn btn-sm btn--tag-like btn-dark-blue">
            Add tag
            <span aria-hidden="true" className="glyphicon glyphicon-plus glyphicon--left"></span>
          </button>
            Severity: Minor
            Found in app/assets/javascripts/components/tags.jsx and 1 other location - About 55 mins to fix
            app/assets/javascripts/components/autocomplete/autocomplete_form.js.jsx on lines 76..78

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language