greenelab/adage-server

View on GitHub
interface/src/app/signature/signature.js

Summary

Maintainability
D
2 days
Test Coverage

File signature.js has 375 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * "adage.signature" module.
 */

angular.module('adage.signature', [
Severity: Minor
Found in interface/src/app/signature/signature.js - About 5 hrs to fix

    Function link has 90 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          link: function($scope) {
            $scope.queryStatus = 'Connecting to the server ...';
            $scope.activities = {};
            $scope.experiments = [];
            $scope.topMode = true;
    Severity: Major
    Found in interface/src/app/signature/signature.js - About 3 hrs to fix

      Function link has 88 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            link: function($scope) {
              $scope.queryStatus = 'Connecting to the server ...';
      
              $scope.topMode = true;
              $scope.topNum = 3;
      Severity: Major
      Found in interface/src/app/signature/signature.js - About 3 hrs to fix

        Function calculateEnrichments has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                var calculateEnrichments = function(geneGenesets, allGenesetInfo,
                                                    totalGeneNum, cutoff) {
                  var N = totalGeneNum;
        
                  // This will be the number of genes from the high weight gene list
        Severity: Minor
        Found in interface/src/app/signature/signature.js - About 2 hrs to fix

          Function link has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                link: function($scope) {
                  $scope.queryStatus = 'Connecting to the server ...';
          
                  $scope.topMode = true;
                  $scope.topNum = 3;
          Severity: Minor
          Found in interface/src/app/signature/signature.js - About 1 hr to fix

            Function handleExperimentResponse has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    var handleExperimentResponse = function(response) {
                      // enhanceExpData: a function that enhances the given experiment.
                      // The enhancements include:
                      // (1) Convert entries in sample_set from sample URI to sample ID,
                      //     and delete samples that are not related to current signature;
            Severity: Minor
            Found in interface/src/app/signature/signature.js - About 1 hr to fix

              Function setSpec has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                this.setSpec = function(activities) {
                  var activityArr = [];
                  var samples = Object.keys(activities);
                  samples.forEach(function(sampleID, index) {
                    activityArr.push({
              Severity: Minor
              Found in interface/src/app/signature/signature.js - About 1 hr to fix

                Function SignatureController has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  function SignatureController(Signature, $stateParams, MlModelTracker, $log,
                                               errGen) {
                    var self = this;
                    if (!$stateParams.id) {
                      self.statusMessage = 'Please specify signature ID in the URL.';
                Severity: Minor
                Found in interface/src/app/signature/signature.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $scope.setMode = function() {
                            $scope.topMode = !$scope.topMode;
                            $scope.numGenesetsShown =
                              $scope.topMode ? $scope.topNum : $scope.enrichedGenesets.length;
                          };
                  Severity: Major
                  Found in interface/src/app/signature/signature.js and 1 other location - About 1 hr to fix
                  interface/src/app/signature/signature.js on lines 79..83

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 66.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          $scope.setMode = function() {
                            $scope.topMode = !$scope.topMode;
                            $scope.numGenesShown =
                              $scope.topMode ? $scope.topNum : $scope.genes.length;
                          };
                  Severity: Major
                  Found in interface/src/app/signature/signature.js and 1 other location - About 1 hr to fix
                  interface/src/app/signature/signature.js on lines 342..346

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 66.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status