Sign upLogin

gregbell/active_admin

View on GitHub
Star
app/controllers/active_admin/resource_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method page_title has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def page_title
      if page_presenter[:title]
        case params[:action].to_sym
        when :index
          case page_presenter[:title]
Severity: Minor
Found in app/controllers/active_admin/resource_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restrict_download_format_access! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def restrict_download_format_access!
      unless request.format.html?
        presenter = active_admin_config.get_page_presenter(:index)
        download_formats = (presenter || {}).fetch(:download_links, active_admin_config.namespace.download_links)
        unless build_download_formats(download_formats).include?(request.format.symbol)
Severity: Minor
Found in app/controllers/active_admin/resource_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status