gregor-j/correct-horse

View on GitHub
src/Dictionaries/DictionaryFile.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Define and throw a dedicated exception instead of using a generic one.
Open

            throw new RuntimeException('File not found: ' . $this->filename);

If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

Noncompliant Code Example

throw new Exception();  // Noncompliant

Compliant Solution

throw new InvalidArgumentException();
// or
throw new UnexpectedValueException();

See

There are no issues that match your filters.

Category
Status