gregor-j/correct-horse

View on GitHub
src/Generators/ManageRandomItemsTrait.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Rename "$items" which has the same name as the field declared at line 21.
Open

        $items = $this->items;

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

There are no issues that match your filters.

Category
Status