gregschmit/rails-rest-framework

View on GitHub

Showing 9 of 9 total issues

Avoid deeply nested control flow statements.
Open

        subcfg = subcfg.in?(fields) ? [] : subcfg
Severity: Major
Found in lib/rest_framework/serializers/native_serializer.rb - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

            subcfg = subcfg.in?(fields) ? subcfg : []
    Severity: Major
    Found in lib/rest_framework/serializers/native_serializer.rb - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if RESTFramework.config.freeze_config
              (self::RRF_BASE_MODEL_CONFIG.keys + self::RRF_BASE_MODEL_INSTANCE_CONFIG.keys).each { |k|
                v = self.send(k)
                v.freeze if v.is_a?(Hash) || v.is_a?(Array)
              }
      Severity: Minor
      Found in lib/rest_framework/mixins/model_controller_mixin.rb and 1 other location - About 25 mins to fix
      lib/rest_framework/mixins/base_controller_mixin.rb on lines 130..134

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if RESTFramework.config.freeze_config
              (self::RRF_BASE_CONFIG.keys + self::RRF_BASE_INSTANCE_CONFIG.keys).each { |k|
                v = self.send(k)
                v.freeze if v.is_a?(Hash) || v.is_a?(Array)
              }
      Severity: Minor
      Found in lib/rest_framework/mixins/base_controller_mixin.rb and 1 other location - About 25 mins to fix
      lib/rest_framework/mixins/model_controller_mixin.rb on lines 366..370

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                RESTFramework::RRF_BUILTIN_ACTIONS.each do |action, methods|
                  next unless controller_class.method_defined?(action)
      
                  [methods].flatten.each do |m|
                    public_send(m, "", action: action) if self.respond_to?(m)
      Severity: Minor
      Found in lib/rest_framework/routers.rb and 2 other locations - About 20 mins to fix
      lib/rest_framework/routers.rb on lines 106..110
      lib/rest_framework/routers.rb on lines 167..171

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                RESTFramework::RRF_BUILTIN_BULK_ACTIONS.each do |action, methods|
                  next unless controller_class.method_defined?(action)
      
                  [methods].flatten.each do |m|
                    public_send(m, "", action: action) if self.respond_to?(m)
      Severity: Minor
      Found in lib/rest_framework/routers.rb and 2 other locations - About 20 mins to fix
      lib/rest_framework/routers.rb on lines 97..101
      lib/rest_framework/routers.rb on lines 167..171

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            RESTFramework::RRF_BUILTIN_BULK_ACTIONS.each do |action, methods|
              next unless self.method_defined?(action)
      
              actions[action] = {
                path: "", methods: methods, type: :builtin, metadata: {label: self.get_label(action)}
      Severity: Minor
      Found in lib/rest_framework/mixins/base_controller_mixin.rb and 1 other location - About 20 mins to fix
      lib/rest_framework/mixins/base_controller_mixin.rb on lines 96..101

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                RESTFramework::RRF_BUILTIN_ACTIONS.each do |action, methods|
                  next unless controller_class.method_defined?(action)
      
                  [methods].flatten.each do |m|
                    public_send(m, "", action: action) if self.respond_to?(m)
      Severity: Minor
      Found in lib/rest_framework/routers.rb and 2 other locations - About 20 mins to fix
      lib/rest_framework/routers.rb on lines 97..101
      lib/rest_framework/routers.rb on lines 106..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            RESTFramework::BUILTIN_MEMBER_ACTIONS.each do |action, methods|
              next unless self.method_defined?(action)
      
              actions[action] = {
                path: "", methods: methods, type: :builtin, metadata: {label: self.get_label(action)}
      Severity: Minor
      Found in lib/rest_framework/mixins/base_controller_mixin.rb and 1 other location - About 20 mins to fix
      lib/rest_framework/mixins/base_controller_mixin.rb on lines 75..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language