Sign upLogin

grigori-gru/jira-to-matrix

View on GitHub
Star
src/bot/commands/command-list/common-actions.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function kick has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

export const kick = async (chatApi: MessengerApi, { id, members }, userToKick?: string) => {
    if (!hasPowerToKick(chatApi.getMyId(), members, EXPECTED_POWER)) {
        logger.debug(`No power for kick in room with id ${id}`);

        return NO_POWER;
Severity: Minor
Found in src/bot/commands/command-list/common-actions.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return ADMINS_EXISTS;
Severity: Major
Found in src/bot/commands/command-list/common-actions.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return ALL_KICKED;
    Severity: Major
    Found in src/bot/commands/command-list/common-actions.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return res.isKicked ? ALL_KICKED : ERROR_KICK;
      Severity: Major
      Found in src/bot/commands/command-list/common-actions.ts - About 30 mins to fix

        Function getGroupedUsers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export const getGroupedUsers = (
    members: { userId: string; powerLevel: number }[],
    botId: string,
): { simpleUsers: string[]; admins: string[]; bot: string[] } => {
    const getGroup = (user: { userId: string; powerLevel: number }) => {
        Severity: Minor
        Found in src/bot/commands/command-list/common-actions.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status