Sign upLogin

grokify/lita-ringcentral

View on GitHub
Star
lib/lita/adapters/ringcentral.rb

Summary

Maintainability
A
0 mins
Test Coverage

Assignment Branch Condition size for initialize is too high. [17.03/15]
Open

      def initialize(robot)
        super
        @connector = Connector.new(
          robot,
          config.app_key,
Severity: Minor
Found in lib/lita/adapters/ringcentral.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [11/10]
Open

      def initialize(robot)
        super
        @connector = Connector.new(
          robot,
          config.app_key,
Severity: Minor
Found in lib/lita/adapters/ringcentral.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Final newline missing.
Open

end
Severity: Minor
Found in lib/lita/adapters/ringcentral.rb by rubocop

Missing top-level module documentation comment.
Open

  module Adapters
Severity: Minor
Found in lib/lita/adapters/ringcentral.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Missing top-level class documentation comment.
Open

    class RingCentral < Adapter
Severity: Minor
Found in lib/lita/adapters/ringcentral.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
Open

          config.sms_number)
Severity: Minor
Found in lib/lita/adapters/ringcentral.rb by rubocop

This cop checks that the closing brace in a method call is either on the same line as the last method argument, or a new line.

When using the symmetrical (default) style:

If a method call's opening brace is on the same line as the first argument of the call, then the closing brace should be on the same line as the last argument of the call.

If an method call's opening brace is on the line above the first argument of the call, then the closing brace should be on the line below the last argument of the call.

When using the new_line style:

The closing brace of a multi-line method call must be on the line after the last argument of the call.

When using the same_line style:

The closing brace of a multi-line method call must be on the same line as the last argument of the call.

Example:

# symmetrical: bad
  # new_line: good
  # same_line: bad
  foo(a,
    b
  )

  # symmetrical: bad
  # new_line: bad
  # same_line: good
  foo(
    a,
    b)

  # symmetrical: good
  # new_line: bad
  # same_line: good
  foo(a,
    b)

  # symmetrical: good
  # new_line: good
  # same_line: bad
  foo(
    a,
    b
  )

There are no issues that match your filters.

Category
Status