grokify/lita-ringcentral

View on GitHub
lita-ringcentral.gemspec

Summary

Maintainability
Test Coverage

%q-literals should be delimited by ( and ).
Open

  spec.description   = %q{A RingCentral SMS adapter for Lita.}
Severity: Minor
Found in lita-ringcentral.gemspec by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency coveralls should appear before simplecov.
Open

  spec.add_development_dependency 'coveralls', '~> 0'
Severity: Minor
Found in lita-ringcentral.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

Prefer $INPUT_RECORD_SEPARATOR or $RS from the stdlib 'English' module (don't forget to require it) over $/.
Open

  spec.files         = `git ls-files`.split($/)
Severity: Minor
Found in lita-ringcentral.gemspec by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  spec.email         = ["johncwang@gmail.com"]
Severity: Minor
Found in lita-ringcentral.gemspec by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

%q-literals should be delimited by ( and ).
Open

  spec.summary       = %q{A RingCentral SMS adapter for the Lita chat robot.}
Severity: Minor
Found in lita-ringcentral.gemspec by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.description   = %q{A RingCentral SMS adapter for Lita.}
Severity: Minor
Found in lita-ringcentral.gemspec by rubocop

Use %q only for strings that contain both single quotes and double quotes.
Open

  spec.summary       = %q{A RingCentral SMS adapter for the Lita chat robot.}
Severity: Minor
Found in lita-ringcentral.gemspec by rubocop

There are no issues that match your filters.

Category
Status