grokify/mogo

View on GitHub
text/currencyutil/parse.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function ParseCurrency has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func ParseCurrency(opts *ParseCurrencyOpts, s string) (string, float64, error) {
    try := strings.TrimSpace(s)
    if len(try) == 0 {
        return "", 0, nil
    }
Severity: Minor
Found in text/currencyutil/parse.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ParseCurrency has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ParseCurrency(opts *ParseCurrencyOpts, s string) (string, float64, error) {
    try := strings.TrimSpace(s)
    if len(try) == 0 {
        return "", 0, nil
    }
Severity: Minor
Found in text/currencyutil/parse.go - About 1 hr to fix

    Function ParseCurrency has 5 return statements (exceeds 4 allowed).
    Open

    func ParseCurrency(opts *ParseCurrencyOpts, s string) (string, float64, error) {
        try := strings.TrimSpace(s)
        if len(try) == 0 {
            return "", 0, nil
        }
    Severity: Major
    Found in text/currencyutil/parse.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status