Sign upLogin

grokify/mogo

View on GitHub
Star
time/duration/durationbin/bins.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function BuildBinsDefault has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
Open

func BuildBinsDefault(durs []time.Duration, extLeft, extRight *time.Duration) Bins {
    durs = slicesutil.Dedupe(durs)
    if len(durs) == 0 {
        if extLeft == nil && extRight == nil {
            return Bins{}
Severity: Minor
Found in time/duration/durationbin/bins.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function BuildBinsDefault has 11 return statements (exceeds 4 allowed).
Open

func BuildBinsDefault(durs []time.Duration, extLeft, extRight *time.Duration) Bins {
    durs = slicesutil.Dedupe(durs)
    if len(durs) == 0 {
        if extLeft == nil && extRight == nil {
            return Bins{}
Severity: Major
Found in time/duration/durationbin/bins.go - About 1 hr to fix

    Function BuildBinsDefault has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func BuildBinsDefault(durs []time.Duration, extLeft, extRight *time.Duration) Bins {
    durs = slicesutil.Dedupe(durs)
    if len(durs) == 0 {
        if extLeft == nil && extRight == nil {
            return Bins{}
    Severity: Minor
    Found in time/duration/durationbin/bins.go - About 1 hr to fix

      Function BuildBinsDuration has 8 return statements (exceeds 4 allowed).
      Open

      func BuildBinsDuration(d, extLeft, extRight time.Duration) Bins {
    if extLeft == extRight {
        if d < extRight {
            return BuildBinsDurationLeftRight(d, extRight)
        } else {
      Severity: Major
      Found in time/duration/durationbin/bins.go - About 50 mins to fix

        Avoid deeply nested control flow statements.
        Open

                } else if extLeft != nil {
            return BuildBinsDurationLeftRight(*extLeft, durs[0])
        } else {
            return BuildBinsDurationLeftRight(durs[0], *extRight)
        }
        Severity: Major
        Found in time/duration/durationbin/bins.go - About 45 mins to fix

          Function BinFromDuration has 5 return statements (exceeds 4 allowed).
          Open

          func BinFromDuration(d time.Duration) Bin {
    // cycle through default bins with non-standard durations.
    defBins := BinsDefault()
    for i, bin := range defBins { // asc
        if d == bin.Duration {
          Severity: Major
          Found in time/duration/durationbin/bins.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status