grokify/mogo

View on GitHub
time/timeutil/quarter_int.go

Summary

Maintainability
A
3 hrs
Test Coverage

Function AnyStringToQuarterTime has 6 return statements (exceeds 4 allowed).
Open

func AnyStringToQuarterTime(yyyyqSrcStr string) time.Time {
    yyyyqSrcStr = strings.TrimSpace(yyyyqSrcStr)
    // If not a string, return now time.
    if len(yyyyqSrcStr) != 5 {
        return time.Now().UTC()
Severity: Major
Found in time/timeutil/quarter_int.go - About 40 mins to fix

    Function NumQuartersInt32 has 5 return statements (exceeds 4 allowed).
    Open

    func NumQuartersInt32(start, end int32) (int, error) {
        start, end = mathutil.MinMaxInt32(start, end)
        if !IsQuarterInt32(start) {
            return -1, fmt.Errorf("quarterInt32 is not valid [%v] Must end in [1-4]", start)
        }
    Severity: Major
    Found in time/timeutil/quarter_int.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ParseHalf(yyyyh int32) (int32, uint8, error) {
          yyyy := int32(float32(yyyyh) / 10.0)
          h := yyyyh - 10*yyyy
          if h < 0 {
              h = -1 * h
      Severity: Minor
      Found in time/timeutil/quarter_int.go and 1 other location - About 1 hr to fix
      time/timeutil/quarter_int.go on lines 105..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 128.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ParseQuarterInt32(yyyyq int32) (int32, uint8, error) {
          yyyy := int32(float32(yyyyq) / 10.0)
          q := yyyyq - 10*yyyy
          if q < 0 {
              q = -1 * q
      Severity: Minor
      Found in time/timeutil/quarter_int.go and 1 other location - About 1 hr to fix
      time/timeutil/quarter_int.go on lines 172..182

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 128.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status