Sign upLogin

grokify/ringcentral-sdk-ruby

View on GitHub
Star

Showing 129 of 129 total issues

Convert if nested inside else to elsif.
Open

          if built_url =~ %r{/$}
Severity: Minor
Found in lib/ringcentral_sdk/rest/client.rb by rubocop

If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

Example:

# bad
if condition_a
  action_a
else
  if condition_b
    action_b
  else
    action_c
  end
end

# good
if condition_a
  action_a
elsif condition_b
  action_b
else
  action_c
end

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

        if _hash_has_string_keys hash
Severity: Minor
Found in lib/ringcentral_sdk/rest/event.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

        if opts.key? :text
Severity: Minor
Found in lib/ringcentral_sdk/rest/messages.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Missing space after #.
Open

#require File.expand_path('../lib/ringcentral_sdk/version', __FILE__)
Severity: Minor
Found in ringcentral_sdk.gemspec by rubocop

This cop checks whether comments have a leading space after the # denoting the start of the comment. The leading space is not required for some RDoc special syntax, like #++, #--, #:nodoc, =begin- and =end comments, "shebang" directives, or rackup options.

Example:

# bad
#Some comment

# good
# Some comment

Do not prefix writer method names with set_.
Open

      def set_token(token)
Severity: Minor
Found in lib/ringcentral_sdk/rest/client.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

Use the return of the conditional for variable assignment and comparison.
Open

          if built_url =~ %r{/$}
            built_url += url
          else
            built_url += '/' << url
          end
Severity: Minor
Found in lib/ringcentral_sdk/rest/client.rb by rubocop

Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

        unless @config.username.to_s.empty?
Severity: Minor
Found in lib/ringcentral_sdk/rest/client.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Useless assignment to variable - req.
Open

          req = inflate_request req, opts
Severity: Minor
Found in lib/ringcentral_sdk/rest/simple_client.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Use casecmp instead of downcase ==.
Open

          @retry = @retry.to_s.strip.downcase == 'true' ? true : false
Severity: Minor
Found in lib/ringcentral_sdk/rest/configuration.rb by rubocop

This cop identifies places where a case-insensitive string comparison can better be implemented using casecmp.

Example:

# bad
str.downcase == 'abc'
str.upcase.eql? 'ABC'
'abc' == str.downcase
'ABC'.eql? str.upcase
str.downcase == str.downcase

# good
str.casecmp('ABC').zero?
'abc'.casecmp(str).zero?

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

            if @extensions_hash.key?(extension_id)
Severity: Minor
Found in lib/ringcentral_sdk/rest/cache/extensions.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Place the condition on the same line as if.
Open

          (s.key?('deliveryMode') && s['deliveryMode']) \
          && (s['deliveryMode'].key?('subscriberKey') && s['deliveryMode']['subscriberKey']) \
          && (
            s['deliveryMode'].key?('address') \
            && !s['deliveryMode']['address'].nil? \
Severity: Minor
Found in lib/ringcentral_sdk/rest/subscription.rb by rubocop

This cop checks for conditions that are not on the same line as if/while/until.

Example:

# bad

if
  some_condition
  do_something
end

Example:

# good

if some_condition
  do_something
end

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

        if req_sdk.params.is_a? Hash
Severity: Minor
Found in lib/ringcentral_sdk/rest/client.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

          if opts[:body].is_a?(Hash)
Severity: Minor
Found in lib/ringcentral_sdk/rest/simple_client.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

            if data.key? :to
Severity: Minor
Found in lib/ringcentral_sdk/rest/request/fax.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Unused method argument - ssl_on. If it's necessary, use _ or _ssl_on as an argument name to indicate that it won't be used.
Open

      def new_pubnub(subscribe_key = '', ssl_on = false, publish_key = '', my_logger = nil)
Severity: Minor
Found in lib/ringcentral_sdk/rest/subscription.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Do not prefix writer method names with set_.
Open

      def set_events(events)
Severity: Minor
Found in lib/ringcentral_sdk/rest/subscription.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

Space inside } missing.
Open

        skip = {text: 1, files: 1}
Severity: Minor
Found in lib/ringcentral_sdk/rest/messages.rb by rubocop

Checks that braces used for hash literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that hash literals have
# surrounding space.

# bad
h = {a: 1, b: 2}

# good
h = { a: 1, b: 2 }

Example: EnforcedStyle: no_space

# The `no_space` style enforces that hash literals have
# no surrounding space.

# bad
h = { a: 1, b: 2 }

# good
h = {a: 1, b: 2}

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# hash braces, with the exception that successive left
# braces or right braces are collapsed together in nested hashes.

# bad
h = { a: { b: 2 } }

# good
h = { a: { b: 2 }}

Avoid the use of Perl-style backrefs.
Open

version = $1
Severity: Minor
Found in ringcentral_sdk.gemspec by rubocop

This cop looks for uses of Perl-style regexp match backreferences like $1, $2, etc.

Example:

# bad
puts $1

# good
puts Regexp.last_match(1)

Useless assignment to variable - req.
Open

          res = @http.delete { |req| req = inflate_request(req, request_sdk) }
Severity: Minor
Found in lib/ringcentral_sdk/rest/client.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Unused method argument - my_logger. If it's necessary, use _ or _my_logger as an argument name to indicate that it won't be used.
Open

      def new_pubnub(subscribe_key = '', ssl_on = false, publish_key = '', my_logger = nil)
Severity: Minor
Found in lib/ringcentral_sdk/rest/subscription.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end
Severity
Category
Status
Source
Language