grokify/ringcentral-sdk-ruby

View on GitHub
lib/ringcentral_sdk/rest/simple_client.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Cyclomatic complexity for send is too high. [8/6]
Open

      def send(request)
        return @client.request(request) if request.is_a? RingCentralSdk::Helpers::Request
        raise(ArgumentError, 'Request is not a ...Helpers::Request or Hash') unless request.is_a? Hash

        verb = request.key?(:verb) ? request[:verb].to_s.downcase : 'get'

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for send is too high. [8/7]
Open

      def send(request)
        return @client.request(request) if request.is_a? RingCentralSdk::Helpers::Request
        raise(ArgumentError, 'Request is not a ...Helpers::Request or Hash') unless request.is_a? Hash

        verb = request.key?(:verb) ? request[:verb].to_s.downcase : 'get'

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method build_url has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def build_url(path)
        path = [path] unless path.is_a? Array

        unless path.empty?
          path0 = path[0].to_s
Severity: Minor
Found in lib/ringcentral_sdk/rest/simple_client.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def send(request)
        return @client.request(request) if request.is_a? RingCentralSdk::Helpers::Request
        raise(ArgumentError, 'Request is not a ...Helpers::Request or Hash') unless request.is_a? Hash

        verb = request.key?(:verb) ? request[:verb].to_s.downcase : 'get'
Severity: Minor
Found in lib/ringcentral_sdk/rest/simple_client.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return delete(request) if verb == 'delete'
Severity: Major
Found in lib/ringcentral_sdk/rest/simple_client.rb - About 30 mins to fix

    Useless assignment to variable - req.
    Open

              req = inflate_request req, opts

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Useless assignment to variable - req.
    Open

              req = inflate_request req, opts

    This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

    assigned but unused variable - foo

    Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

    Example:

    # bad
    
    def some_method
      some_var = 1
      do_something
    end

    Example:

    # good
    
    def some_method
      some_var = 1
      do_something(some_var)
    end

    Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
    Open

              if opts[:body].is_a?(Hash)

    Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

    Example:

    # bad
    if condition
      do_stuff(bar)
    end
    
    unless qux.empty?
      Foo.do_something
    end
    
    # good
    do_stuff(bar) if condition
    Foo.do_something unless qux.empty?

    There are no issues that match your filters.

    Category
    Status