groupdocs-comparison/GroupDocs.Comparison-for-Java-Spring

View on GitHub

Showing 6 of 6 total issues

File ComparisonServiceImpl.java has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.groupdocs.ui.comparison;

import com.groupdocs.comparison.Comparer;
import com.groupdocs.comparison.common.delegates.Delegates;
import com.groupdocs.comparison.interfaces.IDocumentInfo;
Severity: Minor
Found in src/main/java/com/groupdocs/ui/comparison/ComparisonServiceImpl.java - About 2 hrs to fix

    Method loadFiles has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
        public List<FileDescriptionEntity> loadFiles(FileTreeRequest fileTreeRequest) {
            final String path = fileTreeRequest.getPath();
            final File filesDirectory = new File(Path.combine(comparisonConfiguration.getFilesDirectory(), path));
    
    

      Method uploadFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static String uploadFile(String documentStoragePath, MultipartFile content, String url, Boolean rewrite) {
              String filePath;
              try {
                  String fileName;
                  // save from file content
      Severity: Minor
      Found in src/main/java/com/groupdocs/ui/util/Utils.java - About 1 hr to fix

        Method loadFiles has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
            public List<FileDescriptionEntity> loadFiles(FileTreeRequest fileTreeRequest) {
                final String path = fileTreeRequest.getPath();
                final File filesDirectory = new File(Path.combine(comparisonConfiguration.getFilesDirectory(), path));
        
        
        Severity: Minor
        Found in src/main/java/com/groupdocs/ui/comparison/ComparisonServiceImpl.java - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method uploadFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static String uploadFile(String documentStoragePath, MultipartFile content, String url, Boolean rewrite) {
                String filePath;
                try {
                    String fileName;
                    // save from file content
        Severity: Minor
        Found in src/main/java/com/groupdocs/ui/util/Utils.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getYamlPropertiesFactoryBean has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static YamlPropertiesFactoryBean getYamlPropertiesFactoryBean() {
                YamlPropertiesFactoryBean propertiesFactoryBean = new YamlPropertiesFactoryBean();
                ClassPathResource defaultResource = new ClassPathResource(DEFAULT_CONFIGURATION_FILE);
        
                File file = StringUtils.isEmpty(configurationFile) ? null : new File(configurationFile);
        Severity: Minor
        Found in src/main/java/com/groupdocs/ui/Application.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language