gruberb/chartistAngularDirective

View on GitHub

Showing 6 of 6 total issues

Function ngChartist has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ngChartist($compile) {
  return {
    scope: {
      data: '=',
      options: '@',
Severity: Minor
Found in src/chartistAngularDirective.js - About 1 hr to fix

    Function exports has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {
    
      // Project configuration.
      grunt.initConfig({
        pkg: grunt.file.readJSON('package.json'),
    Severity: Minor
    Found in Gruntfile.js - About 1 hr to fix

      Function link has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function link(scope) {
      
          var graph = Chartist[scope.type]('#' + scope.id, scope.data, scope.options, scope.responsiveOptions);
      
          // set watcher for future data updates
      Severity: Minor
      Found in src/chartistAngularDirective.js - About 1 hr to fix

        Function exports has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function(config) {
            config.set({
        
                // base path that will be used to resolve all patterns (eg. files, exclude)
                basePath: '',
        Severity: Minor
        Found in karma.conf.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              scope.$watch('options', function(newValue, oldValue) {
                if(newValue === oldValue) {
                  return;
                }
                graph.update(scope.options, true);
          Severity: Minor
          Found in src/chartistAngularDirective.js and 1 other location - About 50 mins to fix
          src/chartistAngularDirective.js on lines 26..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              scope.$watch('data', function(newValue, oldValue) {
                if(newValue === oldValue) {
                  return;
                }
                graph.update(scope.data, true);
          Severity: Minor
          Found in src/chartistAngularDirective.js and 1 other location - About 50 mins to fix
          src/chartistAngularDirective.js on lines 34..39

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language