gsouf/UForm

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php
/**
 * @license see LICENSE
 */

Found in src/UForm/Filter/Trim.php and 2 other locations - About 1 hr to fix

Read up
Read up

src/UForm/Filter/LeftTrim.php on lines 1..63

src/UForm/Filter/RightTrim.php on lines 1..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Method `validate` has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate(ValidationItem $validationItem)
    {
        $value = $validationItem->getValue();

        if (null === $value) {

Found in src/UForm/Validator/Regexp.php - About 1 hr to fix

Method `validate` has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate(ValidationItem $validationItem)
    {
        $value = $validationItem->getValue();

        if (!is_numeric($value) || !(int)$value == $value) {

Found in src/UForm/Validator/IntegerValue.php - About 1 hr to fix

Function `processCsrf` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function processCsrf($builderOptions)
    {

        // Check if csrf interface was set in the option
        if (isset($builderOptions['csrf']) && $builderOptions['csrf']) {

Found in src/UForm/Builder.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `render` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function render($localData, array $options = [], \UForm\Form\FormContext $formContext = null)
    {

        $options = $this->processRenderOptionHandlers($localData, $options);

Found in src/UForm/Form/Element/Primary/TextArea.php - About 1 hr to fix

Method `moveTo` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function moveTo($destination)
    {
        if ($this->hasError()) {
            throw new Exception('Cannot move the uploaded file because the upload ended with an error.');
        }

Found in src/UForm/FileUpload.php - About 1 hr to fix

Method `__parseProperties` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function __parseProperties(array $p = null)
    {

        if (null === $p) {
            $p = [];

Found in src/UForm/Tag.php - About 1 hr to fix

Method `render` has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function render($localData, array $options = [], \UForm\Form\FormContext $formContext = null)
    {

        $options = $this->processRenderOptionHandlers($localData, $options);

Found in src/UForm/Form/Element/Primary/Input.php - About 1 hr to fix

Function `render` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function render($value)
    {

        $tag = new Tag('option');

Found in src/UForm/Form/Element/Primary/Select/Option.php - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `validate` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate(ValidationItem $validationItem)
    {

        $element = $validationItem->getElement();
        if (!$element instanceof File) {

Found in src/UForm/Validator/File/AbstractFileValidator.php - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `childrenAreValid` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function childrenAreValid()
    {
        if ($this->element instanceof Container) {
            foreach ($this->element->getElements($this->getValue()) as $element) {
                if (!$this->formContext->elementIsValid($element)) {

Found in src/UForm/Validation/ValidationItem.php - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `arrayGet` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function arrayGet(array $data, $string, $rOffset = 0)
    {

        if (is_null($string) || empty($string)) {
            return $data;

Found in src/UForm/Navigator.php - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `getName` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function getName($prenamed = null, $dottedNotation = false)
    {
        if (null === $this->name) {
            // if prenamed and dotted notation dont do further check that's stored in $this->prename
            if ($prenamed && $dottedNotation) {

Found in src/UForm/Form/Element/Container/Group.php - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `range` has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function range($name, $label = null, $defaultValue = null, $min = null, $max = null, $step = null)

Found in src/UForm/Builder/InputBuilder.php - About 45 mins to fix

Function `moveTo` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function moveTo($destination)
    {
        if ($this->hasError()) {
            throw new Exception('Cannot move the uploaded file because the upload ended with an error.');
        }

Found in src/UForm/FileUpload.php - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `getDirectElement` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function getDirectElement($name, $values = null)
    {
        foreach ($this->getElements($values) as $elm) {
            if ($name == $elm->getName()) {
                return $elm;

Found in src/UForm/Form/Element/Container.php - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `bind` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function bind($data)
    {

        foreach ($data as $key => $value) {
            //Check if the item is in the whitelist

Found in src/UForm/DataBind/Binder.php - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if ($element instanceof Requirable) {
            $valid = $element->isDefined($validationItem);
        } else {
            $localName = $validationItem->getLocalName();
            $valid = is_array($value)

Found in src/UForm/Validator/Required.php - About 40 mins to fix

Function `validate` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate(ValidationItem $validationItem)
    {
        $value = $validationItem->getValue();

        if (!is_numeric($value) || !(int)$value == $value) {

Found in src/UForm/Validator/IntegerValue.php - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `addFiltersFor` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function addFiltersFor($path, array $filters)
    {

        if (is_string($path)) {
            $name = $path;

Found in src/UForm/Filtering/FilterChain.php - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading