Sign upLogin

gsouf/zero-table

View on GitHub
Star

Showing 51 of 51 total issues

Function selectRow has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        selectRow : function(tableInstance, $row, selectionType){

            var maxSelection = this.getOption("maxSelection", tableInstance);
            var plugin = this;
Severity: Minor
Found in src/plugins/selection.js - About 1 hr to fix

    Function afterDrawCell has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            "afterDrawCell": function(e){

            if(e.cell.hasRole("data")){
                var value;
                if(!e.columnDef.options.render && e.columnDef.options.content){
    Severity: Minor
    Found in src/plugins/renderCell.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function TableInstance has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ZeroTable.TableInstance = function(table, datapool, options){

    if(table instanceof ZeroTable.Table){

        this.table = table;
    Severity: Minor
    Found in src/ZeroTable/TableInstance.js - About 1 hr to fix

      Function SortDetails has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ZeroTable.Tools.SortDetails = function(table, options){

    this.options = {};
    options = options || {};
      Severity: Minor
      Found in src/ZeroTable/Tools/SortDetails.js - About 1 hr to fix

        Function parseFilters has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function parseFilters(data, filters){
            if(filters.length > 0){
                for(var i = 0; i<filters.length; i++){

                    var params = filters[i].match(/\(.*\)/g);
        Severity: Minor
        Found in src/ZeroTable/StringRenderParser.js - About 1 hr to fix

          Function afterDrawCell has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  "afterDrawCell": function(e){

            var plugin = this.plugin;

            e.cell.$cell.click(function(clickEvent){
          Severity: Minor
          Found in src/plugins/clickEvent.js - About 1 hr to fix

            Function makeRowSelection has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    makeRowSelection: function(tableInstance, $row, largeSelection){

            // check if we already reached the max selection
            var maxSelection = this.getOption("maxSelection", tableInstance);
            if(maxSelection === 0){
            Severity: Minor
            Found in src/plugins/selection.js - About 1 hr to fix

              Function stringRendererParser has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              ZeroTable.stringRendererParser = function(options){

    options = options || {};

    this.filters = {
              Severity: Minor
              Found in src/ZeroTable/StringRenderParser.js - About 1 hr to fix

                Function loadPlugin has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                ZeroTable.loadPlugin = function(plugin, options) {
    if(typeof plugin == "string"){

        if(ZeroTable._plugins.hasOwnProperty(plugin)){
                Severity: Minor
                Found in src/ZeroTable/loadPlugin.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function drawHeaderColumns has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        drawHeaderColumns: function($row, tableInstance){

            var self = this;

            var colsLength = tableInstance.table.columns.length;
                Severity: Minor
                Found in src/plugins/searchHeader.js - About 1 hr to fix

                  Function afterDrawCell has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          "afterDrawCell": function(e){

            if(e.cell.hasRole("data")){
                var value;
                if(!e.columnDef.options.render && e.columnDef.options.content){
                  Severity: Minor
                  Found in src/plugins/renderCell.js - About 1 hr to fix

                    Function showSearcher has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        showSearcher: function(filterName){

        if(this.$filtersList.find('.zt-filter-item[zt-filter-name="' + filterName + '"]').length > 0){
            return;
        }
                    Severity: Minor
                    Found in src/ZeroTable/Tools/SearchDetails.js - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                              if(orderPerColumn[columnName] === 'asc'){
                            if(!item.classList.contains('zt-column-order-asc')){
                                item.classList.remove('zt-column-order-desc');
                                item.classList.add('zt-column-order-asc');
                            }
                      Severity: Minor
                      Found in src/plugins/header.js and 1 other location - About 55 mins to fix
                      src/plugins/header.js on lines 79..84

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 54.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                              } else {
                            if(!item.classList.contains('zt-column-order-desc')){
                                item.classList.remove('zt-column-order-asc');
                                item.classList.add('zt-column-order-desc');
                            }
                      Severity: Minor
                      Found in src/plugins/header.js and 1 other location - About 55 mins to fix
                      src/plugins/header.js on lines 74..79

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 54.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                          update : function(delay){

        var transactionId = this.__generateGuid;
        this._currentTransaction = transactionId;
                      Severity: Minor
                      Found in src/ZeroTable/DataConnector.js - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function extend has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                      ZeroTable.extend = function(toExtend, extendsObjects) {

  if ( ! toExtend ) {
    toExtend = {};
  } else if ( toExtend instanceof Array && !extendsObjects ) {
                      Severity: Minor
                      Found in src/ZeroTable/extend.js - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid deeply nested control flow statements.
                      Open

                                      }else if( selectionType === 1 ){
                    this.rowSetSelection(tableInstance, $row, true);
                }else{
                    this.rowSetSelection(tableInstance, $row, false);
                }
                      Severity: Major
                      Found in src/plugins/selection.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if($row.hasClass(plugin.getOption("selectionClass"))){
                        this.rowSetSelection(tableInstance, $row, false);
                    }else{
                        this.rowSetSelection(tableInstance, $row, true);
                    }
                        Severity: Major
                        Found in src/plugins/selection.js - About 45 mins to fix

                          Function TableInstance has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                          ZeroTable.TableInstance = function(table, datapool, options){

    if(table instanceof ZeroTable.Table){

        this.table = table;
                          Severity: Minor
                          Found in src/ZeroTable/TableInstance.js - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function build has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              build: function(resource, options){

        if(typeof resource == "string"){

            if(this.searchers.hasOwnProperty(resource)){
                          Severity: Minor
                          Found in src/ZeroTable/Plugin/SearchHeader/SearcherFactory.js - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language