Sign upLogin

guar47/project-lvl3-s14

View on GitHub
Star

Showing 5 of 5 total issues

Function pageLoader has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

const pageLoader = async (address, outputDir = '.') => {
  try {
    const htmlResponse = await axios.get(address);
    const tmpDir = fs.mkdtempSync(`${os.tmpdir()}${path.sep}`);
    const $ = cheerio.load(htmlResponse.data);
Severity: Minor
Found in src/index.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function pageLoader has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const pageLoader = async (address, outputDir = '.') => {
  try {
    const htmlResponse = await axios.get(address);
    const tmpDir = fs.mkdtempSync(`${os.tmpdir()}${path.sep}`);
    const $ = cheerio.load(htmlResponse.data);
Severity: Major
Found in src/index.js - About 2 hrs to fix

    Function data has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          const data = await Promise.all(links.map(async (link) => {
        let linkEdit = '';
        if (link[0] === '/' && link[1] === '/') {
          linkEdit = `http:${link}`;
        } else if (link[0] === '/') {
    Severity: Minor
    Found in src/index.js - About 1 hr to fix

      Unexpected console statement.
      Open

            console.log(colors.red(error));
      Severity: Minor
      Found in src/bin/downloader-bin.js by eslint

      disallow the use of console (no-console)

      In JavaScript that is designed to be executed in the browser, it's considered a best practice to avoid using methods on console. Such messages are considered to be for debugging purposes and therefore not suitable to ship to the client. In general, calls using console should be stripped before being pushed to production.

      console.log("Made it here.");
console.error("That shouldn't have happened.");

      Rule Details

      This rule disallows calls to methods of the console object.

      Examples of incorrect code for this rule:

      /*eslint no-console: "error"*/

console.log("Log a debug level message.");
console.warn("Log a warn level message.");
console.error("Log an error level message.");

      Examples of correct code for this rule:

      /*eslint no-console: "error"*/

// custom console
Console.log("Hello world!");

      Options

      This rule has an object option for exceptions:

      • "allow" has an array of strings which are allowed methods of the console object

      Examples of additional correct code for this rule with a sample { "allow": ["warn", "error"] } option:

      /*eslint no-console: ["error", { allow: ["warn", "error"] }] */

console.warn("Log a warn level message.");
console.error("Log an error level message.");

      When Not To Use It

      If you're using Node.js, however, console is used to output information to the user and so is not strictly used for debugging purposes. If you are developing for Node.js then you most likely do not want this rule enabled.

      Related Rules

      Unexpected console statement.
      Open

            console.log(colors.green(result));
      Severity: Minor
      Found in src/bin/downloader-bin.js by eslint

      disallow the use of console (no-console)

      In JavaScript that is designed to be executed in the browser, it's considered a best practice to avoid using methods on console. Such messages are considered to be for debugging purposes and therefore not suitable to ship to the client. In general, calls using console should be stripped before being pushed to production.

      console.log("Made it here.");
console.error("That shouldn't have happened.");

      Rule Details

      This rule disallows calls to methods of the console object.

      Examples of incorrect code for this rule:

      /*eslint no-console: "error"*/

console.log("Log a debug level message.");
console.warn("Log a warn level message.");
console.error("Log an error level message.");

      Examples of correct code for this rule:

      /*eslint no-console: "error"*/

// custom console
Console.log("Hello world!");

      Options

      This rule has an object option for exceptions:

      • "allow" has an array of strings which are allowed methods of the console object

      Examples of additional correct code for this rule with a sample { "allow": ["warn", "error"] } option:

      /*eslint no-console: ["error", { allow: ["warn", "error"] }] */

console.warn("Log a warn level message.");
console.error("Log an error level message.");

      When Not To Use It

      If you're using Node.js, however, console is used to output information to the user and so is not strictly used for debugging purposes. If you are developing for Node.js then you most likely do not want this rule enabled.

      Related Rules

      Severity
      Category
      Status
      Source
      Language