Sign upLogin

gui-gui/omnipay-payu-brazil

View on GitHub
Star

Showing 18 of 18 total issues

AbstractRequest has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractRequest extends BaseAbstractRequest
{

    protected $liveEndpoint = 'https://api.payulatam.com/payments-api/4.0/service.cgi';
    protected $testEndpoint = 'https://sandbox.api.payulatam.com/payments-api/4.0/service.cgi';
Severity: Minor
Found in src/Message/AbstractRequest.php - About 3 hrs to fix

    Function setRefundState has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function setRefundState()
    {
        if(!isset($this->data['error']))
        {   
            // Check if request is pending
    Severity: Minor
    Found in src/Message/RefundResponse.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getData has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getData()
    {
        $this->validate(
            'amount',
            'currency',
    Severity: Minor
    Found in src/Message/AuthorizeRequest.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function testSendSuccess()
    {
        $this->setMockHttpResponse('AuthorizeSuccess.txt');
        $response = $this->request->send();
      Severity: Major
      Found in tests/Message/AuthorizeRequestTest.php and 1 other location - About 1 hr to fix
      tests/Message/AuthorizeRequestTest.php on lines 240..253

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function testRefundSuccess()
    {
        $this->setMockHttpResponse('RefundSuccess.txt');
        $response = $this->request->send();
      Severity: Major
      Found in tests/Message/RefundResponseTest.php and 2 other locations - About 1 hr to fix
      tests/Message/RefundResponseTest.php on lines 49..61
      tests/Message/RefundResponseTest.php on lines 63..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function testRefundDeclined()
    {
        $this->setMockHttpResponse('RefundDeclined.txt');
        $response = $this->request->send();
      Severity: Major
      Found in tests/Message/RefundResponseTest.php and 2 other locations - About 1 hr to fix
      tests/Message/RefundResponseTest.php on lines 20..33
      tests/Message/RefundResponseTest.php on lines 49..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function testSendFailure()
    {
        $this->setMockHttpResponse('AuthorizeFailure.txt');
        $response = $this->request->send();
      Severity: Major
      Found in tests/Message/AuthorizeRequestTest.php and 1 other location - About 1 hr to fix
      tests/Message/AuthorizeRequestTest.php on lines 225..238

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function testRefundNonResolved()
    {
        $this->setMockHttpResponse('RefundNonResolved.txt');
        $response = $this->request->send();
      Severity: Major
      Found in tests/Message/RefundResponseTest.php and 2 other locations - About 1 hr to fix
      tests/Message/RefundResponseTest.php on lines 20..33
      tests/Message/RefundResponseTest.php on lines 63..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method setRefundState has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function setRefundState()
    {
        if(!isset($this->data['error']))
        {   
            // Check if request is pending
      Severity: Minor
      Found in src/Message/RefundResponse.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function testRefund()
    {
        $request = $this->gateway->refund($this->getValidRequest());

        $requestData = $request->getData();
        Severity: Major
        Found in tests/GatewayTest.php and 1 other location - About 1 hr to fix
        tests/GatewayTest.php on lines 79..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function testCapture()
    {
        $request = $this->gateway->capture($this->getValidRequest());
        
        $requestData = $request->getData();
        Severity: Major
        Found in tests/GatewayTest.php and 1 other location - About 1 hr to fix
        tests/GatewayTest.php on lines 102..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 108.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method testGetData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testGetData()
    {   
        $card = $this->getValidCard();

        $this->request->setCard($card);
        Severity: Minor
        Found in tests/Message/AuthorizeRequestTest.php - About 1 hr to fix

          Method testGetDataForBoletoPaymentMethod has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testGetDataForBoletoPaymentMethod()
    {
        $this->request = new AuthorizeRequest($this->getHttpClient(), $this->getHttpRequest());
        $this->request->initialize(
            array(
          Severity: Minor
          Found in tests/Message/AuthorizeRequestTest.php - About 1 hr to fix

            Method testNullBoletoExpirationDate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testNullBoletoExpirationDate()
    {
        $this->request = new AuthorizeRequest($this->getHttpClient(), $this->getHttpRequest());
        $this->request->initialize(
            array(
            Severity: Minor
            Found in tests/Message/AuthorizeRequestTest.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      $this->request->initialize(
            array(
                'amount' => '12.00',                
                'payment_method' => 'BOLETO',
                'card' => $this->getValidCard(),
              Severity: Minor
              Found in tests/Message/AuthorizeRequestTest.php and 1 other location - About 55 mins to fix
              tests/Message/AuthorizeRequestTest.php on lines 198..217

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 98.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      $this->request->initialize(
            array(
                'amount' => '12.00',
                'paymentMethod' => 'VISA',
                'card' => $this->getValidCard(),
              Severity: Minor
              Found in tests/Message/AuthorizeRequestTest.php and 1 other location - About 55 mins to fix
              tests/Message/AuthorizeRequestTest.php on lines 121..140

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 98.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function getData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getData()
    {
        $this->validate(
            'amount',
            'currency',
              Severity: Minor
              Found in src/Message/AuthorizeRequest.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return;
              Severity: Major
              Found in src/Message/RefundResponse.php - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language