Sign upLogin

gui-gui/omnipay-payu-brazil

View on GitHub
Star

Showing 9 of 18 total issues

AbstractRequest has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractRequest extends BaseAbstractRequest
{

    protected $liveEndpoint = 'https://api.payulatam.com/payments-api/4.0/service.cgi';
    protected $testEndpoint = 'https://sandbox.api.payulatam.com/payments-api/4.0/service.cgi';
Severity: Minor
Found in src/Message/AbstractRequest.php - About 3 hrs to fix

    Function setRefundState has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function setRefundState()
    {
        if(!isset($this->data['error']))
        {   
            // Check if request is pending
    Severity: Minor
    Found in src/Message/RefundResponse.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getData has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getData()
    {
        $this->validate(
            'amount',
            'currency',
    Severity: Minor
    Found in src/Message/AuthorizeRequest.php - About 1 hr to fix

      Method setRefundState has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function setRefundState()
    {
        if(!isset($this->data['error']))
        {   
            // Check if request is pending
      Severity: Minor
      Found in src/Message/RefundResponse.php - About 1 hr to fix

        Method testGetData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testGetData()
    {   
        $card = $this->getValidCard();

        $this->request->setCard($card);
        Severity: Minor
        Found in tests/Message/AuthorizeRequestTest.php - About 1 hr to fix

          Method testGetDataForBoletoPaymentMethod has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testGetDataForBoletoPaymentMethod()
    {
        $this->request = new AuthorizeRequest($this->getHttpClient(), $this->getHttpRequest());
        $this->request->initialize(
            array(
          Severity: Minor
          Found in tests/Message/AuthorizeRequestTest.php - About 1 hr to fix

            Method testNullBoletoExpirationDate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testNullBoletoExpirationDate()
    {
        $this->request = new AuthorizeRequest($this->getHttpClient(), $this->getHttpRequest());
        $this->request->initialize(
            array(
            Severity: Minor
            Found in tests/Message/AuthorizeRequestTest.php - About 1 hr to fix

              Function getData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getData()
    {
        $this->validate(
            'amount',
            'currency',
              Severity: Minor
              Found in src/Message/AuthorizeRequest.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return;
              Severity: Major
              Found in src/Message/RefundResponse.php - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language