Sign upLogin

guibranco/GuiStracini.HolidayAPI

View on GitHub
Star

Showing 7 of 7 total issues

Consider simplifying this complex logical expression.
Open

            if (
                propertyValue == null
                || (propertyType == typeof(int) && Convert.ToInt32(propertyValue) == 0)
                || (propertyType == typeof(long) && Convert.ToInt64(propertyValue) == 0)
                || (
Severity: Critical
Found in Src/GuiStracini.HolidayAPI/Utils/RequestHelpers.cs - About 1 hr to fix

    Method GetRequestEndpoint has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public static string GetRequestEndpoint(this BaseRequest request)
        {
            var matchData = new ProcessMatchData { Type = request.GetType() };

            var endpointAttribute = request.GetRequestEndpointAttribute();
    Severity: Minor
    Found in Src/GuiStracini.HolidayAPI/Utils/RequestHelpers.cs - About 1 hr to fix

      Method ProcessMatch has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private static void ProcessMatch(
            BaseRequest request,
            Match match,
            ProcessMatchData matchData
        )
      Severity: Minor
      Found in Src/GuiStracini.HolidayAPI/Utils/RequestHelpers.cs - About 1 hr to fix

        Method ParseProperty has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private static bool ParseProperty(
            BaseRequest request,
            PropertyInfo property,
            bool addAsQueryString,
            StringBuilder builder
        Severity: Minor
        Found in Src/GuiStracini.HolidayAPI/Utils/RequestHelpers.cs - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public async Task<IEnumerable<ICountry>> GetCountriesAsync(
            string search,
            CancellationToken cancellationToken
        )
        {
          Severity: Major
          Found in Src/GuiStracini.HolidayAPI/HolidayAPIClient.cs and 1 other location - About 1 hr to fix
          Src/GuiStracini.HolidayAPI/HolidayAPIClient.cs on lines 222..239

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  public async Task<IEnumerable<ILanguage>> GetLanguagesAsync(
            string search,
            CancellationToken cancellationToken
        )
        {
          Severity: Major
          Found in Src/GuiStracini.HolidayAPI/HolidayAPIClient.cs and 1 other location - About 1 hr to fix
          Src/GuiStracini.HolidayAPI/HolidayAPIClient.cs on lines 184..202

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Consider simplifying this complex logical expression.
          Open

                      if (
                propertyType == typeof(string)
                || propertyType == typeof(bool)
                || (propertyType == typeof(int) && Convert.ToInt32(propertyValue) > 0)
                || (propertyType == typeof(long) && Convert.ToInt64(propertyValue) > 0)
          Severity: Major
          Found in Src/GuiStracini.HolidayAPI/Utils/RequestHelpers.cs - About 40 mins to fix
            Severity
            Category
            Status
            Source
            Language