Sign upLogin

guibranco/Pancake

View on GitHub
Star
src/Color.php

Summary

Maintainability
A
2 hrs
Test Coverage
B
81%

Function generateColorFromText has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function generateColorFromText(string $text, int $minBrightness = 100, int $spec = 10): Color
    {
        if ($spec < 2 || $spec > 10) {
            throw new InvalidArgumentException("$spec is out of range");
        }
Severity: Minor
Found in src/Color.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generateColorFromText has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function generateColorFromText(string $text, int $minBrightness = 100, int $spec = 10): Color
    {
        if ($spec < 2 || $spec > 10) {
            throw new InvalidArgumentException("$spec is out of range");
        }
Severity: Minor
Found in src/Color.php - About 1 hr to fix

    The method generateColorFromText() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

        public function generateColorFromText(string $text, int $minBrightness = 100, int $spec = 10): Color
    {
        if ($spec < 2 || $spec > 10) {
            throw new InvalidArgumentException("$spec is out of range");
        }
    Severity: Minor
    Found in src/Color.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Argument 3 ($pad_string) is 0 of type 0 but \str_pad() takes string
    Open

                $output .= str_pad(dechex($colors[$i]), 2, 0, STR_PAD_LEFT);
    Severity: Minor
    Found in src/Color.php by phan

    Argument #2 of this call to \str_pad is typically a literal or constant but isn't, but argument #1 (which is typically a variable) is a literal or constant. The arguments may be in the wrong order.
    Open

                $current = round(((hexdec(substr($hash, $spec * $i, $spec))) / hexdec(str_pad("", $spec, "F"))) * 255);
    Severity: Minor
    Found in src/Color.php by phan

    Saw an @param annotation for $hexColor, but it was not found in the param list of function setRed(string $red) : void
    Open

         * @param string $hexColor The hex color.
    Severity: Info
    Found in src/Color.php by phan

    Invalid operator: left operand of * is string (expected number)
    Open

            return ($this->red * 0.2126 + $this->green * 0.7152 + $this->blue * 0.0722) / 255;
    Severity: Minor
    Found in src/Color.php by phan

    Possibly invalid offset $i of $colors of array type array{0?:mixed}
    Open

                        $colors[$i] += 10;
    Severity: Minor
    Found in src/Color.php by phan

    Possibly invalid offset $i of $colors of array type array{0?:float|int|mixed}
    Open

                $output .= str_pad(dechex($colors[$i]), 2, 0, STR_PAD_LEFT);
    Severity: Minor
    Found in src/Color.php by phan

    There are no issues that match your filters.

    Category
    Status