Sign upLogin

guibranco/Pancake

View on GitHub
Star
src/OneSignal.php

Summary

Maintainability
A
0 mins
Test Coverage
A
90%

The method sendInternal has a boolean flag argument $isRetry, which is a certain sign of a Single Responsibility Principle violation.
Open

    private function sendInternal($content, $headers, $isRetry = false)
Severity: Minor
Found in src/OneSignal.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Call to method log on non-class type ?mixed
Open

            $this->logger->log("Error sending OneSignal", json_encode($result));
Severity: Critical
Found in src/OneSignal.php by phan

There are no issues that match your filters.

Category
Status