Sign upLogin

guyellis/multi-level-cache

View on GitHub
Star

Showing 13 of 13 total issues

Function MultiCacheResult has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

var MultiCacheResult = (function(){
  function MultiCache(localCache, remoteCache, options) {
    this.options = options || {};

    this.useLocalCacheDefault = this.options.hasOwnProperty('useLocalCache') ?
Severity: Minor
Found in lib/multi.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MultiCacheResult has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var MultiCacheResult = (function(){
  function MultiCache(localCache, remoteCache, options) {
    this.options = options || {};

    this.useLocalCacheDefault = this.options.hasOwnProperty('useLocalCache') ?
Severity: Major
Found in lib/multi.js - About 5 hrs to fix

    Function getCacheInterface has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

    function getCacheInterface(client, errorState) {
  function getError() {
    return new MultiError(errorState.message);
  }
    Severity: Minor
    Found in lib/cache-lib/redis.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getCacheInterface has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getCacheInterface(client, errorState) {
  function getError() {
    return new MultiError(errorState.message);
  }
    Severity: Major
    Found in lib/cache-lib/redis.js - About 2 hrs to fix

      Function exports has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(options) {

  var nodeCache = new NodeCache(options);

  return {
      Severity: Minor
      Found in lib/cache-lib/node-cache.js - About 1 hr to fix

        Function get has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          MultiCache.prototype.get = function(keys, options, callback) {
    var self = this;
    if(typeof options === 'function') {
      callback = options;
      options = null;
        Severity: Minor
        Found in lib/multi.js - About 1 hr to fix

          Function exports has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function(options) {

  var errorState = {
    isError: false,
    message: ''
          Severity: Minor
          Found in lib/cache-lib/redis.js - About 1 hr to fix

            Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function(options) {

  var nodeCache = new NodeCache(options);

  return {
            Severity: Minor
            Found in lib/cache-lib/node-cache.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              MultiCache.prototype._useLocalCache = function(options) {
    if(options && options.hasOwnProperty('useLocalCache')) {
      return options.useLocalCache;
    }
    return this.useLocalCacheDefault;
            Severity: Minor
            Found in lib/multi.js and 1 other location - About 55 mins to fix
            lib/multi.js on lines 148..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              MultiCache.prototype._useRemoteCache = function(options) {
    if(options && options.hasOwnProperty('useRemoteCache')) {
      return options.useRemoteCache;
    }
    return this.useRemoteCacheDefault;
            Severity: Minor
            Found in lib/multi.js and 1 other location - About 55 mins to fix
            lib/multi.js on lines 141..146

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function set has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              MultiCache.prototype.set = function(key, value, ttl, options, callback) {
            Severity: Minor
            Found in lib/multi.js - About 35 mins to fix

              Function _set has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                MultiCache.prototype._set = function(key, value, ttl, options, callback) {
              Severity: Minor
              Found in lib/multi.js - About 35 mins to fix

                Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                module.exports = function(options) {

  var errorState = {
    isError: false,
    message: ''
                Severity: Minor
                Found in lib/cache-lib/redis.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language