Sign upLogin

gwpy/gwosc

View on GitHub
Star
gwosc/datasets.py

Summary

Maintainability
D
2 days
Test Coverage

File datasets.py has 528 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright (C) Cardiff University (2018-2021)
# SPDX-License-Identifier: MIT

"""
Severity: Major
Found in gwosc/datasets.py - About 1 day to fix

    Function _iter_datasets has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def _iter_datasets(
        detector=None,
        type=None,
        segment=None,
        catalog=None,
    Severity: Minor
    Found in gwosc/datasets.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _event_datasets has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def _event_datasets(
        detector=None,
        segment=None,
        catalog=None,
        version=None,
    Severity: Minor
    Found in gwosc/datasets.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function find_datasets has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def find_datasets(
    Severity: Major
    Found in gwosc/datasets.py - About 50 mins to fix

      Function _iter_datasets has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _iter_datasets(
      Severity: Major
      Found in gwosc/datasets.py - About 50 mins to fix

        Function _match_event_dataset has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _match_event_dataset(
        Severity: Minor
        Found in gwosc/datasets.py - About 45 mins to fix

          Function event_segment has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def event_segment(
          Severity: Minor
          Found in gwosc/datasets.py - About 35 mins to fix

            Function _event_metadata has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _event_metadata(
            Severity: Minor
            Found in gwosc/datasets.py - About 35 mins to fix

              Function _event_datasets has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def _event_datasets(
              Severity: Minor
              Found in gwosc/datasets.py - About 35 mins to fix

                Avoid too many return statements within this function.
                Open

                        return True
                Severity: Major
                Found in gwosc/datasets.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return False
                  Severity: Major
                  Found in gwosc/datasets.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return utils.segments_overlap(segment, eseg)
                    Severity: Major
                    Found in gwosc/datasets.py - About 30 mins to fix

                      Function _match_event_dataset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def _match_event_dataset(
        dataset,
        catalog=None,
        version=None,
        detector=None,
                      Severity: Minor
                      Found in gwosc/datasets.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      There are no issues that match your filters.

                      Category
                      Status