gyrodraw/GyroDraw

File index.js has 374 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// The Cloud Functions for Firebase SDK to create Cloud Functions and setup triggers.
const functions = require('firebase-functions');

// The Firebase Admin SDK to access the Firebase Realtime Database.
const admin = require('firebase-admin');

Function functionTimer has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function functionTimer (seconds, state, roomID, isWaiting, call) {
  return new Promise((resolve, reject) => {
    // This represents the maximum time allowed for firebase.
    if (seconds > 300) {
        return;

Function joinGame has 39 lines of code (exceeds 25 allowed). Consider refactoring.

Open

exports.joinGame = functions.https.onCall((data, context) => {
  const id = data.id;
  const username = data.username;
  const league = data.league - 1;
  const gameMode = data.mode;

Function onInterval has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function onInterval() {

      if (stop === true) {
        stop = false;
        throw new "Timer stopped";

Function updateUser has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function updateUser(userID) {
  return admin.database().ref("users/").once('value', (snapshot) => {
    if(snapshot.hasChild(userID)) {
      let newTrophies;
      let totalMatches;

Function startTimer has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

function startTimer(time, roomID, prevState, newState, nodeCreation, isWaiting) {

Function createRoomAndJoin has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

function createRoomAndJoin(league, roomsList, username, id, gameMode) {

Function functionTimer has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

function functionTimer (seconds, state, roomID, isWaiting, call) {

Avoid too many return statements within this function.

Open

  return 0;

Avoid too many return statements within this function.

Open

      return admin.database().ref(parentRoomID + roomID + "/ranking").once('value', (snapshot) => {
        return updateDisconnectedUsers(snapshot, roomID);
      });

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            promises.push(admin.database().ref(parentRoomID + roomID + "/playing").set(PlayingEnum.Idle));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            promises.push(admin.database().ref(parentRoomID + roomID + "/state").set(StateEnum.Idle));

• Read up
  Read up