Sign upLogin

h2non/rocky

View on GitHub
Star

Showing 111 of 111 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    supertest(proxyUrl)
      .get('/test')
      .expect(502)
      .expect('Content-Type', 'application/json')
      .expect(/ENOTFOUND/)
Severity: Minor
Found in test/http.js and 1 other location - About 40 mins to fix
test/http.js on lines 976..981

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function replayHandler has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function replayHandler (route, params, opts, req, next) {
Severity: Minor
Found in lib/protocols/http/passes/replay.js - About 35 mins to fix

    Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports = function wsProxy (opts, req, socket, head, done) {
    Severity: Minor
    Found in lib/protocols/ws/proxy.js - About 35 mins to fix

      Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      module.exports = function (opts, req, socket, head, done) {
      Severity: Minor
      Found in lib/protocols/ws/passes/forward.js - About 35 mins to fix

        Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            rockyStub.mw = { run: function (a, b, c, d, next) { next() } }
        Severity: Minor
        Found in test/server/server.js - About 35 mins to fix

          Function replayer has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function replayer (route, replayReq, replayRes, opts, next) {
          Severity: Minor
          Found in lib/protocols/http/passes/replay.js - About 35 mins to fix

            Function concurrently has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            exports.concurrently = function (opts, req, socket, head, done) {
            Severity: Minor
            Found in lib/protocols/ws/passes/index.js - About 35 mins to fix

              Function run has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  rockyStub.mw = { run: function (a, b, c, d, next) { next() } }
              Severity: Minor
              Found in test/server/server.js - About 35 mins to fix

                Function forwardStrategy has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function forwardStrategy (route, opts, req, res, resolver) {
                Severity: Minor
                Found in lib/protocols/http/passes/forward.js - About 35 mins to fix

                  Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  module.exports = function replay (route, opts, req, res, next) {
                  Severity: Minor
                  Found in lib/protocols/http/passes/replay.js - About 35 mins to fix

                    Function dispatchConcurrently has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    Dispatcher.prototype.dispatchConcurrently = function (opts, req, socket, head, done) {
                    Severity: Minor
                    Found in lib/protocols/ws/dispatcher.js - About 35 mins to fix

                      Function forwardRetryRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function forwardRetryRequest (route, opts, forwardReq, res, done) {
                      Severity: Minor
                      Found in lib/protocols/http/passes/forward.js - About 35 mins to fix

                        Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        module.exports = function forward (route, opts, req, res, done) {
                        Severity: Minor
                        Found in lib/protocols/http/passes/forward.js - About 35 mins to fix

                          Function forwardRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          function forwardRequest (route, opts, forwardReq, res, done) {
                          Severity: Minor
                          Found in lib/protocols/http/passes/forward.js - About 35 mins to fix

                            Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            module.exports = function (opts, res, task, done, onRetry) {
                            Severity: Minor
                            Found in lib/protocols/http/retry.js - About 35 mins to fix

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                              Route.prototype.redirect = function (url) {
  this.use(middleware.redirect(url))
  return this
}
                              Severity: Major
                              Found in lib/route.js and 3 other locations - About 35 mins to fix
                              lib/base.js on lines 178..181
                              lib/base.js on lines 191..194
                              lib/route.js on lines 31..34

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 47.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                              Route.prototype.host = function (host) {
  this.use(middleware.host(host))
  return this
}
                              Severity: Major
                              Found in lib/route.js and 3 other locations - About 35 mins to fix
                              lib/base.js on lines 178..181
                              lib/base.js on lines 191..194
                              lib/route.js on lines 75..78

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 47.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                              Base.prototype.headers = function (headers) {
  this.use(middleware.headers(headers))
  return this
}
                              Severity: Major
                              Found in lib/base.js and 3 other locations - About 35 mins to fix
                              lib/base.js on lines 191..194
                              lib/route.js on lines 31..34
                              lib/route.js on lines 75..78

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 47.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                              Base.prototype.query = function (query) {
  this.use(middleware.query(query))
  return this
}
                              Severity: Major
                              Found in lib/base.js and 3 other locations - About 35 mins to fix
                              lib/base.js on lines 178..181
                              lib/route.js on lines 31..34
                              lib/route.js on lines 75..78

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 47.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Function dispatch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                              Open

                              Dispatcher.prototype.dispatch = function (req, res, next) {
  if (this.route.unregistered) return next('route')

  const route = this.route
  const opts = this.options()
                              Severity: Minor
                              Found in lib/protocols/http/dispatcher.js - About 35 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language