h2non/videoshow

View on GitHub

Showing 9 of 9 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

videoshow(images, options)
  .audio(audio)
  .save('video.mp4')
  .on('start', function (command) {
    console.log('ffmpeg process started:', command)
Severity: Major
Found in examples/captions.js and 1 other location - About 3 hrs to fix
examples/transition.js on lines 31..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

videoshow(images, options)
  .audio(audio)
  .save('video.mp4')
  .on('start', function (command) {
    console.log('ffmpeg process started:', command)
Severity: Major
Found in examples/transition.js and 1 other location - About 3 hrs to fix
examples/captions.js on lines 51..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function renderVideo has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function renderVideo(videoshow, options, forwardEvent, cb) {
  var tempfile = randomName()
  var output = videoshow.output
  var audio = videoshow.audioFile
  var videoParams = videoshow.videoParams
Severity: Major
Found in lib/render.js - About 2 hrs to fix

    File render.js has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var fs = require('fs')
    var fw = require('fw')
    var os = require('os')
    var path = require('path')
    var uuid = require('lil-uuid')
    Severity: Minor
    Found in lib/render.js - About 2 hrs to fix

      Function getImageSubtitles has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getImageSubtitles(videoshow) {
        var filepath = null
        var params = options.define(videoshow.params)
        var extension = '.ass'
      
      
      Severity: Minor
      Found in lib/render.js - About 1 hr to fix

        Function applyVideo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.applyVideo = function (video, options) {
          Object.keys(options).forEach(function (key) {
            var method = video[key]
            var arg = options[key]
        
        
        Severity: Minor
        Found in lib/options.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function mergeParts has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function mergeParts(videoshow, bus) {
          var forwardEvent = proxyEvent(bus)
          var output = videoshow.output
        
          return function (err, images) {
        Severity: Minor
        Found in lib/render.js - About 1 hr to fix

          Function getImageSubtitles has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function getImageSubtitles(videoshow) {
            var filepath = null
            var params = options.define(videoshow.params)
            var extension = '.ass'
          
          
          Severity: Minor
          Found in lib/render.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function renderVideo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function renderVideo(videoshow, options, forwardEvent, cb) {
            var tempfile = randomName()
            var output = videoshow.output
            var audio = videoshow.audioFile
            var videoParams = videoshow.videoParams
          Severity: Minor
          Found in lib/render.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language