Sign upLogin

hack4impact/maps4all

View on GitHub
Star
app/models/csv.py

Summary

Maintainability
C
1 day
Test Coverage

Function set_desc_values has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def set_desc_values(self):
        all_descs = self.csv_descriptors
        opt_descs = dict([(d.name, d) for d in all_descs if d.descriptor_type == 'option'])
        for row in self.csv_rows:
            for key in row.data:
Severity: Minor
Found in app/models/csv.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if desc.values:
                            values = desc.values
                        val = val.split(';')
Severity: Major
Found in app/models/csv.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            for v in val:
                            if v.strip():
                                values.add(v.strip())
                        desc.values = values
    Severity: Major
    Found in app/models/csv.py - About 45 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          def value_list(self):
        if not self.values:
            return []
        l = list(self.values)
        map(str, l)
      Severity: Major
      Found in app/models/csv.py and 1 other location - About 1 hr to fix
      app/models/resource.py on lines 143..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @staticmethod
    def most_recent(user):
        return CsvStorage.query.filter_by(user=user).order_by(
            desc(CsvStorage.date_uploaded)
      Severity: Major
      Found in app/models/csv.py and 1 other location - About 1 hr to fix
      app/models/bulk.py on lines 56..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 43.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status