Issues - hack4impact/maps4all

Function `submitCsvData` has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function submitCsvData(numRows, rowObjects, fields) {
  // Create list of Ajax requests: first processing the fields of the CSV then
  // the rows
  var ajaxReqs = [];
  var resetOrUpdate = document.getElementById('reset').checked

Found in app/assets/scripts/upload-csv.js - About 4 hrs to fix

Similar blocks of code found in 42 locations. Consider refactoring.
Open

quail.guidelines.wcag.successCriteria['2.2.4'] = (function (quail) {
  /**
   * Determines if this Success Criteria applies to the document.
   */
  function preEvaluator() {

Found in app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js and 41 other locations - About 4 hrs to fix

Read up
Read up

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 8448..8469

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 8504..8525

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 8588..8609

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 8611..8632

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 8634..8655

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 8798..8819

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 8984..9005

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9007..9028

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9030..9051

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9053..9074

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9076..9097

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9099..9120

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9122..9143

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9145..9166

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9168..9189

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9191..9212

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9237..9258

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9260..9281

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9283..9304

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9337..9358

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9360..9381

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9383..9404

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9406..9427

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9429..9450

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9452..9473

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9475..9496

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9498..9519

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9521..9542

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9544..9565

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9567..9588

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9590..9611

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9613..9634

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9636..9657

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9659..9680

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9803..9824

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9826..9847

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9849..9870

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9972..9993

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 9995..10016

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 10018..10039

app/static/ckeditor/plugins/a11ychecker/libs/quail/quail.jquery.js on lines 10041..10062

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

hack4impact/maps4all

Showing 457 of 457 total issues

Function submitCsvData has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 42 locations. Consider refactoring. Open

Duplicated Code

Function `submitCsvData` has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open

Similar blocks of code found in 42 locations. Consider refactoring.
Open