Sign upLogin

hackedteam/core-android-market

View on GitHub
Star
src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py

Summary

Maintainability
F
5 days
Test Coverage

Function publish_test_logs has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

def publish_test_logs(
    input_dirs,
    runner_id, tag, platform, comment_file, timestamp, user, source, run_type,
    dart_server = None,
    http_proxy = None,
Severity: Minor
Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File collect_and_upload_logs.py has 456 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright (c) MetaCommunications, Inc. 2003-2007
#
# Distributed under the Boost Software License, Version 1.0. 
# (See accompanying file LICENSE_1_0.txt or copy at 
# http://www.boost.org/LICENSE_1_0.txt)
Severity: Minor
Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 6 hrs to fix

    Function collect_and_upload_logs has 17 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def collect_and_upload_logs(
    Severity: Major
    Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 2 hrs to fix

      Function collect_logs has 13 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def collect_logs(
      Severity: Major
      Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 1 hr to fix

        Function publish_test_logs has 12 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def publish_test_logs(
        Severity: Major
        Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 1 hr to fix

          Function upload_logs has 11 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def upload_logs(
          Severity: Major
          Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                    if node.nodeType == xml.dom.Node.ELEMENT_NODE:
                            if node.firstChild:
                                log_data = xml.sax.saxutils.escape(node.firstChild.data)
                            else:
                                log_data = ''
            Severity: Major
            Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 45 mins to fix

              Function upload_to_ftp has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def upload_to_ftp( tag, results_file, ftp_proxy, debug_level, ftp_url ):
              Severity: Minor
              Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 35 mins to fix

                Function copy_comments has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                def copy_comments( results_xml, comment_file ):
    results_xml.startElement( 'comment', {} )

    if os.path.exists( comment_file ):
        utils.log( 'Reading comments file "%s"...' % comment_file )
                Severity: Minor
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function upload_to_ftp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def upload_to_ftp( tag, results_file, ftp_proxy, debug_level, ftp_url ):
    
    if not ftp_url:
        ftp_host = 'boost.cowic.de'
        ftp_url = ''.join(['ftp','://anonymous','@',ftp_host,'/boost/do-not-publish-this-url/results/'])
                Severity: Minor
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function compress_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def compress_file( file_path, archive_path ):
    utils.log( 'Compressing "%s"...' % file_path )

    try:
        z = zipfile.ZipFile( archive_path, 'w', zipfile.ZIP_DEFLATED )
                Severity: Minor
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    try:
        z = zipfile.ZipFile( archive_path, 'w', zipfile.ZIP_DEFLATED )
        z.write( file_path, os.path.basename( file_path ) )
        z.close()
        utils.log( 'Done writing "%s".'% archive_path )
                Severity: Major
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py and 1 other location - About 1 day to fix
                src/libbson/boost/boost_1_53_0/tools/regression/src/regression.py on lines 753..774

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 153.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                if __name__ != '__main__':  import utils
else:
    # in absense of relative import...
    xsl_path = os.path.abspath( os.path.dirname( sys.argv[ 0 ] ) )
    while os.path.basename( xsl_path ) != 'xsl_reports': xsl_path = os.path.dirname( xsl_path )
                Severity: Major
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py and 1 other location - About 5 hrs to fix
                src/libbson/boost/boost_1_53_0/tools/regression/xsl_reports/make_snapshot.py on lines 166..174

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if not test['test-name'] or test['test-name'] == '':
                        test['test-name'] = 'unknown'
                Severity: Major
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py and 1 other location - About 1 hr to fix
                src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py on lines 118..119

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if not test['toolset'] or test['toolset'] == '':
                        test['toolset'] = 'unknown'
                Severity: Major
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py and 1 other location - About 1 hr to fix
                src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py on lines 116..117

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 42.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    for input_dir in input_dirs:
        utils.log( 'Walking directory "%s" ...' % input_dir )
        os.path.walk( input_dir, _publish_test_log_files_, None )
                Severity: Minor
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py and 1 other location - About 40 mins to fix
                src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py on lines 46..48

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    for input_dir in input_dirs:
        utils.log( 'Walking directory "%s" ...' % input_dir )
        os.path.walk( input_dir, process_test_log_files, test_results_writer )
                Severity: Minor
                Found in src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py and 1 other location - About 40 mins to fix
                src/libbson/boost/boost_1_53_0/tools/regression/src/collect_and_upload_logs.py on lines 163..165

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 34.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status