Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
InjectionFramework/src/blackberry/injection/FieldExplorer.java

Summary

Maintainability
F
4 days
Test Coverage

Method exploreField has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
Open

    protected static void exploreField(Field field, int deep, String[] history,
            Debug debug, String deleteName) {

        String tab = "";
Severity: Minor
Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method traverseField has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    public static void traverseField(Field field, int deep,
            FieldChangeListener fieldChangeListener) {

        fieldChangeListener.fieldChanged(field, deep);
        if (field instanceof Manager) {
Severity: Minor
Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploreField has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected static void exploreField(Field field, int deep, String[] history,
            Debug debug, String deleteName) {

        String tab = "";
Severity: Major
Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 4 hrs to fix

    File FieldExplorer.java has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package blackberry.injection;

import java.util.Enumeration;
import java.util.Hashtable;
import java.util.Vector;
    Severity: Minor
    Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 3 hrs to fix

      Method accessibleTraverse has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          private static boolean accessibleTraverse(AccessibleContext context,
            int deep, String deleteName) {
        String tab = "";
        boolean ret = false;
        for (int i = 0; i < deep; i++) {
      Severity: Minor
      Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method traverseField has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static void traverseField(Field field, int deep,
            FieldChangeListener fieldChangeListener) {

        fieldChangeListener.fieldChanged(field, deep);
        if (field instanceof Manager) {
      Severity: Major
      Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 2 hrs to fix

        Method accessibleTraverse has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static boolean accessibleTraverse(AccessibleContext context,
            int deep, String deleteName) {
        String tab = "";
        boolean ret = false;
        for (int i = 0; i < deep; i++) {
        Severity: Minor
        Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 1 hr to fix

          Method exploreField has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              protected static void exploreField(Field field, int deep, String[] history,
            Debug debug, String deleteName) {
          Severity: Minor
          Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 35 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                private static String[] addHistory(String[] history, String name) {

        String[] newHistory = new String[history.length + 1];
        for (int i = 0; i < history.length; i++) {
            newHistory[i] = history[i];
            Severity: Major
            Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java and 2 other locations - About 1 hr to fix
            BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java on lines 206..214
            RCSBlackBerry/src/blackberry/injection/FieldExplorer.java on lines 194..202

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                private static String getName(Class class1) {
        String name = class1.getName();
        int index = name.lastIndexOf('.');
        if (index > 0) {
            return name.substring(index + 1);
            Severity: Major
            Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java and 2 other locations - About 40 mins to fix
            BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java on lines 259..266
            RCSBlackBerry/src/blackberry/injection/FieldExplorer.java on lines 238..245

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        for (int i = 0; i < context.getAccessibleChildCount(); i++) {
                accessibleTraverse(context.getAccessibleChildAt(i), deep + 1,
                        deleteName);
            }
            Severity: Minor
            Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java and 2 other locations - About 30 mins to fix
            BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java on lines 252..255
            InjectionFramework/src/blackberry/injection/FieldExplorer.java on lines 314..316

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        for (int i = 0; i < vf.getFieldCount(); i++) {
                traverseField(vf.getField(i), deep + 1, fieldChangeListener);
            }
            Severity: Minor
            Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java and 2 other locations - About 30 mins to fix
            BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/FieldExplorer.java on lines 252..255
            InjectionFramework/src/blackberry/injection/FieldExplorer.java on lines 290..293

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 40.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status