Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/Core.java

Summary

Maintainability
C
1 day
Test Coverage

Method checkPermissions has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private boolean checkPermissions() {

        //#ifdef DEBUG
        debug.trace("CheckPermissions"); //$NON-NLS-1$
        //#endif
Severity: Major
Found in RCSBlackBerry/src/blackberry/Core.java - About 2 hrs to fix

    Method run has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void run() {
        // 7.2= DEMO
        String demo = Status.self().isDemo() ? Messages.getString("7.2") : "";

        //#ifdef DEBUG
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/Core.java - About 1 hr to fix

      Method forceReboot has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static void forceReboot() {
        //TODO: se il telefono e' occupato, attendere il tempo necessario.
        try {

            Backlight.enable(false);
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/Core.java - About 1 hr to fix

        Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public void run() {
        // 7.2= DEMO
        String demo = Status.self().isDemo() ? Messages.getString("7.2") : "";

        //#ifdef DEBUG
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/Core.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method stealth has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void stealth() {

        try {

            final String sCurrentModuleName = ApplicationDescriptor
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/Core.java - About 1 hr to fix

          Method checkPermissions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private boolean checkPermissions() {

        //#ifdef DEBUG
        debug.trace("CheckPermissions"); //$NON-NLS-1$
        //#endif
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/Core.java - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method stealth has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private void stealth() {

        try {

            final String sCurrentModuleName = ApplicationDescriptor
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/Core.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (int i = 0; i < size; i++) {
            final int handle = handles[i];
            //CodeModuleManager.getModuleHandle(name)
            // Retrieve specific information about a module.
            final String name = CodeModuleManager.getModuleName(handle);
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/Core.java and 1 other location - About 1 hr to fix
          RCSBlackBerry/src/blackberry/action/UninstallAction.java on lines 103..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 86.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  for (int i = 0; i < wantedPermissions.length; i++) {
            final int perm = wantedPermissions[i];
            permRequest.addPermission(perm);
        }
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/Core.java and 2 other locations - About 30 mins to fix
          InjectionFramework/src/blackberry/InjectionFrameworkApp.java on lines 375..378
          RCSBlackBerry/src/blackberry/evidence/Markup.java on lines 379..382

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status