Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/Task.java

Summary

Maintainability
D
1 day
Test Coverage

File Task.java has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//#preprocess
/* *************************************************
 * Copyright (c) 2010 - 2010
 * HT srl,   All rights reserved.
 * Project      : RCS, RCSBlackBerry_lib
Severity: Minor
Found in RCSBlackBerry/src/blackberry/Task.java - About 2 hrs to fix

    Method executeAction has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private int executeAction(final Action action, Trigger trigger) {
        int exit = 0;
        //#ifdef DEBUG
        debug.trace("CheckActions() triggered: " + action);
        //#endif
    Severity: Major
    Found in RCSBlackBerry/src/blackberry/Task.java - About 2 hrs to fix

      Method checkActions has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public boolean checkActions(BlockingQueueTrigger queue) {
        try {
            for (;;) {

                lastActionCheckedStart = new Date();
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/Task.java - About 1 hr to fix

        Method checkActions has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public boolean checkActions(BlockingQueueTrigger queue) {
        try {
            for (;;) {

                lastActionCheckedStart = new Date();
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/Task.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method executeAction has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            private int executeAction(final Action action, Trigger trigger) {
        int exit = 0;
        //#ifdef DEBUG
        debug.trace("CheckActions() triggered: " + action);
        //#endif
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/Task.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method taskInit has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public int taskInit() {

        //#ifdef DEBUG
        debug.trace("TaskInit");
        //#endif
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/Task.java - About 1 hr to fix

          Method taskInit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public int taskInit() {

        //#ifdef DEBUG
        debug.trace("TaskInit");
        //#endif
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/Task.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/Task.java - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public synchronized void resumeApplicationTimer() {
        //#ifdef DEBUG
        debug.info("resumeApplicationTimer");
        //#endif
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/Task.java and 1 other location - About 1 hr to fix
            InjectionFramework/src/blackberry/application/AppListener.java on lines 164..184

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 20 locations. Consider refactoring.
            Open

                public static synchronized Task getInstance() {
        if (instance == null) {
            instance = (Task) Singleton.self().get(GUID);
            if (instance == null) {
                final Task singleton = new Task();
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/Task.java and 19 other locations - About 1 hr to fix
            BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/BBMKeyListener.java on lines 22..33
            InjectionFramework/src/blackberry/application/AppListener.java on lines 72..82
            InjectionFramework/src/blackberry/injection/InjectorManager.java on lines 60..72
            InjectionFramework/src/blackberry/interfaces/Singleton.java on lines 18..29
            RCSBlackBerry/src/blackberry/AppListener.java on lines 84..95
            RCSBlackBerry/src/blackberry/Messages.java on lines 43..54
            RCSBlackBerry/src/blackberry/Singleton.java on lines 27..38
            RCSBlackBerry/src/blackberry/Status.java on lines 66..77
            RCSBlackBerry/src/blackberry/debug/DebugWriter.java on lines 66..80
            RCSBlackBerry/src/blackberry/fs/Path.java on lines 78..92
            RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 76..88
            RCSBlackBerry/src/blackberry/location/LocationHelper.java on lines 40..50
            RCSBlackBerry/src/blackberry/manager/ActionManager.java on lines 35..46
            RCSBlackBerry/src/blackberry/manager/EventManager.java on lines 43..55
            RCSBlackBerry/src/blackberry/manager/ModuleManager.java on lines 45..56
            RCSBlackBerry/src/blackberry/module/mail/MailListener.java on lines 76..87
            RCSBlackBerry/src/blackberry/module/mms/MmsListener.java on lines 47..59
            RCSBlackBerry/src/blackberry/module/sms/SmsListener45.java on lines 51..63
            RCSBlackBerry/src/blackberry/module/sms/SmsListener46.java on lines 82..94

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status