Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/event/EventCellId.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method actualLoop has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected void actualLoop() {
        //final boolean gprs = Device.isGPRS();
        int mcc = 0, mnc = 0, lac = 0, cid = 0;

        if (Device.isGPRS()) {
Severity: Major
Found in RCSBlackBerry/src/blackberry/event/EventCellId.java - About 3 hrs to fix

    Method actualLoop has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        protected void actualLoop() {
        //final boolean gprs = Device.isGPRS();
        int mcc = 0, mnc = 0, lac = 0, cid = 0;

        if (Device.isGPRS()) {
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/event/EventCellId.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if ((mccOrig == 0 || mccOrig == mcc)
                && (mncOrig == 0 || mncOrig == mnc)
                && (lacOrig == 0 || lacOrig == lac)
                && (cidOrig == 0 || cidOrig == cid)) {
            if (!entered) {
    Severity: Critical
    Found in RCSBlackBerry/src/blackberry/event/EventCellId.java - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status