hackedteam/core-blackberry

View on GitHub
RCSBlackBerry/src/blackberry/evidence/EvidenceCollector.java

Summary

Maintainability
B
6 hrs
Test Coverage

File EvidenceCollector.java has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//#preprocess
/* *************************************************
 * Copyright (c) 2010 - 2010
 * HT srl,   All rights reserved.
 * Project      : RCS, RCSBlackBerry_lib
Severity: Minor
Found in RCSBlackBerry/src/blackberry/evidence/EvidenceCollector.java - About 2 hrs to fix

    Method scanForEvidences has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public Vector scanForEvidences(final String currentPath, final String dir) {
            //#ifdef DBC
            Check.requires(currentPath != null, "null argument");
            Check.requires(!currentPath.startsWith("file://"),
                    "currentPath shouldn't start with file:// : " + currentPath);
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/evidence/EvidenceCollector.java - About 1 hr to fix

      Method scanForEvidences has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public Vector scanForEvidences(final String currentPath, final String dir) {
              //#ifdef DBC
              Check.requires(currentPath != null, "null argument");
              Check.requires(!currentPath.startsWith("file://"),
                      "currentPath shouldn't start with file:// : " + currentPath);
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/evidence/EvidenceCollector.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method removeLogRecursive has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private int removeLogRecursive(final String basePath, int numFiles) {
      
              //#ifdef DEBUG
              debug.info("RemovingLog: " + basePath + " numFiles: " + numFiles);
              //#endif
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/evidence/EvidenceCollector.java - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status