Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/module/ModulePosition.java

Summary

Maintainability
F
3 days
Test Coverage

File ModulePosition.java has 508 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//#preprocess
/* *************************************************
 * Copyright (c) 2010 - 2010
 * HT srl,   All rights reserved.
 * Project      : RCS, RCSBlackBerry
Severity: Major
Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 1 day to fix

    Method locationCELL has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void locationCELL() {

        //final boolean gprs = !Device.isCDMA();

        if (Device.isGPRS()) {
    Severity: Major
    Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 3 hrs to fix

      Method locationCELL has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          private void locationCELL() {

        //final boolean gprs = !Device.isCDMA();

        if (Device.isGPRS()) {
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getGPSPayload has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private byte[] getGPSPayload(QualifiedCoordinates qc, Location loc,
            long timestamp) {
        //#ifdef DEBUG
        debug.trace("getGPSPayload"); //$NON-NLS-1$
        //#endif
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 1 hr to fix

        Method actualStart has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void actualStart() {
        //#ifdef DEBUG
        debug.trace("actualStart"); //$NON-NLS-1$
        //#endif
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 1 hr to fix

          Method getCellPayload has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private byte[] getCellPayload(int mcc, int mnc, int lac, int cid, int bsid,
            int rssi) {

        final int size = 19 * 4 + 48 + 16;
        final byte[] cellPosition = new byte[size];
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 1 hr to fix

            Method locationGPS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private void locationGPS() {
        //#ifdef DEBUG
        debug.trace("locationGPS"); //$NON-NLS-1$
        //#endif
            Severity: Minor
            Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 1 hr to fix

              Method getWifiPayload has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private byte[] getWifiPayload(String bssid, String ssid, int signalLevel) {
        //#ifdef DEBUG
        debug.trace("getWifiPayload bssid: " + bssid + " ssid: " + ssid //$NON-NLS-1$ //$NON-NLS-2$
                + " signal:" + signalLevel); //$NON-NLS-1$
        //#endif
              Severity: Minor
              Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 1 hr to fix

                Method actualStart has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public void actualStart() {
        //#ifdef DEBUG
        debug.trace("actualStart"); //$NON-NLS-1$
        //#endif
                Severity: Minor
                Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getCellPayload has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private byte[] getCellPayload(int mcc, int mnc, int lac, int cid, int bsid,
            int rssi) {
                Severity: Minor
                Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 45 mins to fix

                  Method locationWIFI has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private void locationWIFI() {
        final WLANAPInfo wifi = WLANInfo.getAPInfo();
        if (wifi != null) {
            if ((RadioInfo.getActiveWAFs() & RadioInfo.WAF_WLAN) != 0) {
                //#ifdef DEBUG
                  Severity: Minor
                  Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          if (gpsEnabled) {
            //#ifdef DEBUG
            debug.trace("actualRun: gps"); //$NON-NLS-1$
            //#endif
            try {
                  Severity: Minor
                  Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java and 2 other locations - About 30 mins to fix
                  RCSBlackBerry/src/blackberry/module/ModulePosition.java on lines 150..162
                  RCSBlackBerry/src/blackberry/module/ModulePosition.java on lines 163..175

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 42.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          if (cellEnabled) {
            //#ifdef DEBUG
            debug.trace("actualRun: cell"); //$NON-NLS-1$
            //#endif
            try {
                  Severity: Minor
                  Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java and 2 other locations - About 30 mins to fix
                  RCSBlackBerry/src/blackberry/module/ModulePosition.java on lines 137..149
                  RCSBlackBerry/src/blackberry/module/ModulePosition.java on lines 163..175

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 42.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          if (wifiEnabled) {
            //#ifdef DEBUG
            debug.trace("actualRun: wifi"); //$NON-NLS-1$
            //#endif
            try {
                  Severity: Minor
                  Found in RCSBlackBerry/src/blackberry/module/ModulePosition.java and 2 other locations - About 30 mins to fix
                  RCSBlackBerry/src/blackberry/module/ModulePosition.java on lines 137..149
                  RCSBlackBerry/src/blackberry/module/ModulePosition.java on lines 150..162

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 42.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status