Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/module/mail/Filter.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method filterMessage has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public final int filterMessage(final Message message, final long lastcheck)
            throws MessagingException {

        //#ifdef DBC
        Check.requires(message != null, "filterMessage: message != null");
Severity: Minor
Found in RCSBlackBerry/src/blackberry/module/mail/Filter.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filterMessage has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public final int filterMessage(final Message message, final long lastcheck)
            throws MessagingException {

        //#ifdef DBC
        Check.requires(message != null, "filterMessage: message != null");
Severity: Minor
Found in RCSBlackBerry/src/blackberry/module/mail/Filter.java - About 2 hrs to fix

    Method toString has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public final String toString() {
        final StringBuffer sb = new StringBuffer();

        switch (classtype) {
            case Filter.CLASS_EMAIL:
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/module/mail/Filter.java - About 1 hr to fix

      Method toString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public final String toString() {
        final StringBuffer sb = new StringBuffer();

        switch (classtype) {
            case Filter.CLASS_EMAIL:
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/module/mail/Filter.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return FILTERED_DATETO;
      Severity: Major
      Found in RCSBlackBerry/src/blackberry/module/mail/Filter.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return FILTERED_OK;
        Severity: Major
        Found in RCSBlackBerry/src/blackberry/module/mail/Filter.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return FILTERED_SIZE;
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/module/mail/Filter.java - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status