Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
RCSBlackBerry/src/blackberry/module/mail/MailListener.java

Summary

Maintainability
F
3 days
Test Coverage

Method lookForPinMessages has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    private Date lookForPinMessages(final Message[] messages)
            throws MessagingException {

        //#ifdef DEBUG
        debug.trace("lookForPinMessages on: " + messages.length);
Severity: Minor
Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File MailListener.java has 358 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//#preprocess

/* *************************************************
 * Copyright (c) 2010 - 2011
 * HT srl,   All rights reserved.
Severity: Minor
Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 4 hrs to fix

    Method scanFolders has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

        public void scanFolders(final String storeName, final Folder[] subfolders) {
        Folder[] dirs;

        Filter collectFilter = ModuleMessage.getInstance()
                .getFilterEmailCollect();
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method scanFolders has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public void scanFolders(final String storeName, final Folder[] subfolders) {
        Folder[] dirs;

        Filter collectFilter = ModuleMessage.getInstance()
                .getFilterEmailCollect();
    Severity: Major
    Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 3 hrs to fix

      Method lookForPinMessages has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private Date lookForPinMessages(final Message[] messages)
            throws MessagingException {

        //#ifdef DEBUG
        debug.trace("lookForPinMessages on: " + messages.length);
      Severity: Major
      Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 2 hrs to fix

        Method messagesAdded has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void messagesAdded(final FolderEvent folderEvent) {
        init();
        
        final Message message = folderEvent.getMessage();
        final String folderName = message.getFolder().getFullName();
        Severity: Minor
        Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (address != null) {
                        //debug.trace("7");
                        final String name = address.getName();
                        if (name != null && name.length() == 8
                                && name.indexOf("@") == -1
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java and 1 other location - About 1 hr to fix
          RCSBlackBerry/src/blackberry/module/mail/MailListener.java on lines 628..642

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                                      if (address != null) {

                                final String name = address.getAddr();
                                if (name != null && name.length() == 8
                                        && name.indexOf("@") == -1
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java and 1 other location - About 1 hr to fix
          RCSBlackBerry/src/blackberry/module/mail/MailListener.java on lines 596..610

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 20 locations. Consider refactoring.
          Open

              public static synchronized MailListener getInstance() {
        if (instance == null) {
            instance = (MailListener) Singleton.self().get(GUID);
            if (instance == null) {
                final MailListener singleton = new MailListener();
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java and 19 other locations - About 1 hr to fix
          BBMInjectDemo/src/com/rim/samples/device/bbminjectdemo/BBMKeyListener.java on lines 22..33
          InjectionFramework/src/blackberry/application/AppListener.java on lines 72..82
          InjectionFramework/src/blackberry/injection/InjectorManager.java on lines 60..72
          InjectionFramework/src/blackberry/interfaces/Singleton.java on lines 18..29
          RCSBlackBerry/src/blackberry/AppListener.java on lines 84..95
          RCSBlackBerry/src/blackberry/Messages.java on lines 43..54
          RCSBlackBerry/src/blackberry/Singleton.java on lines 27..38
          RCSBlackBerry/src/blackberry/Status.java on lines 66..77
          RCSBlackBerry/src/blackberry/Task.java on lines 51..62
          RCSBlackBerry/src/blackberry/debug/DebugWriter.java on lines 66..80
          RCSBlackBerry/src/blackberry/fs/Path.java on lines 78..92
          RCSBlackBerry/src/blackberry/injection/InjectorManager.java on lines 76..88
          RCSBlackBerry/src/blackberry/location/LocationHelper.java on lines 40..50
          RCSBlackBerry/src/blackberry/manager/ActionManager.java on lines 35..46
          RCSBlackBerry/src/blackberry/manager/EventManager.java on lines 43..55
          RCSBlackBerry/src/blackberry/manager/ModuleManager.java on lines 45..56
          RCSBlackBerry/src/blackberry/module/mms/MmsListener.java on lines 47..59
          RCSBlackBerry/src/blackberry/module/sms/SmsListener45.java on lines 51..63
          RCSBlackBerry/src/blackberry/module/sms/SmsListener46.java on lines 82..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status