hackedteam/core-blackberry

View on GitHub
RCSBlackBerry/src/blackberry/record/PipedInputStream.java

Summary

Maintainability
C
1 day
Test Coverage

Method read has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public synchronized int read(byte b[], int off, int len) throws IOException {
        if (b == null) {
            throw new NullPointerException();
        } else if (off < 0 || len < 0 || len > b.length - off) {
            throw new IndexOutOfBoundsException();
Severity: Minor
Found in RCSBlackBerry/src/blackberry/record/PipedInputStream.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method receive has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    synchronized void receive(byte b[], int off, int len) throws IOException {
        checkStateForReceive();
        writeSide = Thread.currentThread();
        int bytesToTransfer = len;
        while (bytesToTransfer > 0) {
Severity: Minor
Found in RCSBlackBerry/src/blackberry/record/PipedInputStream.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public synchronized int read() throws IOException {
        if (!connected) {
            throw new IOException("conn");
        } else if (closedByReader) {
            throw new IOException("closed");
Severity: Minor
Found in RCSBlackBerry/src/blackberry/record/PipedInputStream.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public synchronized int read(byte b[], int off, int len) throws IOException {
        if (b == null) {
            throw new NullPointerException();
        } else if (off < 0 || len < 0 || len > b.length - off) {
            throw new IndexOutOfBoundsException();
Severity: Minor
Found in RCSBlackBerry/src/blackberry/record/PipedInputStream.java - About 1 hr to fix

    Method read has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public synchronized int read() throws IOException {
            if (!connected) {
                throw new IOException("conn");
            } else if (closedByReader) {
                throw new IOException("closed");
    Severity: Minor
    Found in RCSBlackBerry/src/blackberry/record/PipedInputStream.java - About 1 hr to fix

      Method receive has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          synchronized void receive(byte b[], int off, int len) throws IOException {
              checkStateForReceive();
              writeSide = Thread.currentThread();
              int bytesToTransfer = len;
              while (bytesToTransfer > 0) {
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/record/PipedInputStream.java - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status