Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/Initializer.java

Summary

Maintainability
F
3 days
Test Coverage

Method execute has 207 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void execute(ClassPool programClassPool,
                        ClassPool libraryClassPool) throws IOException
    {
        int originalLibraryClassPoolSize = libraryClassPool.size();
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 1 day to fix

    Method execute has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        public void execute(ClassPool programClassPool,
                        ClassPool libraryClassPool) throws IOException
    {
        int originalLibraryClassPoolSize = libraryClassPool.size();
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Initializer.java has 291 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 3 hrs to fix

      Method createClassMemberNoteExceptionMatcher has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          private StringMatcher createClassMemberNoteExceptionMatcher(List    noteExceptions,
                                                                boolean isField)
    {
        if (noteExceptions != null)
        {
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createClassNoteExceptionMatcher has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          private StringMatcher createClassNoteExceptionMatcher(List noteExceptions)
    {
        if (noteExceptions != null)
        {
            List noteExceptionNames = new ArrayList(noteExceptions.size());
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createClassMemberNoteExceptionMatcher has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private StringMatcher createClassMemberNoteExceptionMatcher(List    noteExceptions,
                                                                boolean isField)
    {
        if (noteExceptions != null)
        {
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 1 hr to fix

        Method createClassNoteExceptionMatcher has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private StringMatcher createClassNoteExceptionMatcher(List noteExceptions)
    {
        if (noteExceptions != null)
        {
            List noteExceptionNames = new ArrayList(noteExceptions.size());
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (memberName != null)
                        {
                            noteExceptionNames.add(memberName);
                        }
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/Initializer.java - About 45 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    if (descriptorNoteCount > 0)
        {
            System.out.println("Note: there were " + descriptorNoteCount +
                               " unkept descriptor classes in kept class members.");
            System.out.println("      You should consider explicitly keeping the mentioned classes");
            Severity: Major
            Found in bb-tools/proguard4.7/src/proguard/Initializer.java and 3 other locations - About 40 mins to fix
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 260..266
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 269..275
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 292..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    if (dependencyWarningCount > 0)
        {
            System.err.println("Warning: there were " + dependencyWarningCount +
                               " instances of library classes depending on program classes.");
            System.err.println("         You must avoid such dependencies, since the program classes will");
            Severity: Major
            Found in bb-tools/proguard4.7/src/proguard/Initializer.java and 3 other locations - About 40 mins to fix
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 243..249
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 260..266
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 269..275

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    if (classForNameNoteCount > 0)
        {
            System.out.println("Note: there were " + classForNameNoteCount +
                               " class casts of dynamically created class instances.");
            System.out.println("      You might consider explicitly keeping the mentioned classes and/or");
            Severity: Major
            Found in bb-tools/proguard4.7/src/proguard/Initializer.java and 3 other locations - About 40 mins to fix
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 243..249
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 269..275
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 292..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    if (getmemberNoteCount > 0)
        {
            System.out.println("Note: there were " + getmemberNoteCount +
                               " accesses to class members by means of introspection.");
            System.out.println("      You should consider explicitly keeping the mentioned class members");
            Severity: Major
            Found in bb-tools/proguard4.7/src/proguard/Initializer.java and 3 other locations - About 40 mins to fix
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 243..249
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 260..266
            bb-tools/proguard4.7/src/proguard/Initializer.java on lines 292..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status