Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star
bb-tools/proguard4.7/src/proguard/MemberSpecification.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method equals has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public boolean equals(Object object)
    {
        if (object == null ||
            this.getClass() != object.getClass())
        {
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/MemberSpecification.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            (this.requiredSetAccessFlags   == other.requiredSetAccessFlags                                                                      ) &&
            (this.requiredUnsetAccessFlags == other.requiredUnsetAccessFlags                                                                    ) &&
            (this.annotationType == null ? other.annotationType == null : this.annotationType.equals(other.annotationType)) &&
            (this.name           == null ? other.name           == null : this.name.equals(other.name)                    ) &&
            (this.descriptor     == null ? other.descriptor     == null : this.descriptor.equals(other.descriptor)        );
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/MemberSpecification.java and 1 other location - About 1 hr to fix
bb-tools/proguard4.7/src/proguard/ClassSpecification.java on lines 224..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            (requiredSetAccessFlags                                ) ^
            (requiredUnsetAccessFlags                              ) ^
            (annotationType == null ? 0 : annotationType.hashCode()) ^
            (name           == null ? 0 : name.hashCode()          ) ^
            (descriptor     == null ? 0 : descriptor.hashCode()    );
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/MemberSpecification.java and 1 other location - About 55 mins to fix
bb-tools/proguard4.7/src/proguard/ClassSpecification.java on lines 238..242

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

    public MemberSpecification(int    requiredSetAccessFlags,
                               int    requiredUnsetAccessFlags,
                               String annotationType,
                               String name,
                               String descriptor)
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/MemberSpecification.java and 15 other locations - About 50 mins to fix
bb-tools/proguard4.7/src/proguard/KeepClassSpecification.java on lines 50..61
bb-tools/proguard4.7/src/proguard/classfile/ProgramMember.java on lines 58..69
bb-tools/proguard4.7/src/proguard/classfile/attribute/LocalVariableInfo.java on lines 59..70
bb-tools/proguard4.7/src/proguard/classfile/attribute/LocalVariableTypeInfo.java on lines 60..71
bb-tools/proguard4.7/src/proguard/classfile/attribute/preverification/FullFrame.java on lines 66..77
bb-tools/proguard4.7/src/proguard/classfile/instruction/TableSwitchInstruction.java on lines 48..59
bb-tools/proguard4.7/src/proguard/classfile/util/ClassReferenceInitializer.java on lines 78..89
bb-tools/proguard4.7/src/proguard/classfile/util/DynamicMemberReferenceInitializer.java on lines 520..531
bb-tools/proguard4.7/src/proguard/classfile/visitor/ClassHierarchyTraveler.java on lines 56..68
bb-tools/proguard4.7/src/proguard/classfile/visitor/MethodImplementationTraveler.java on lines 57..68
bb-tools/proguard4.7/src/proguard/gui/splash/ImageSprite.java on lines 47..58
bb-tools/proguard4.7/src/proguard/gui/splash/ShadowedSprite.java on lines 51..62
bb-tools/proguard4.7/src/proguard/io/ClassReader.java on lines 55..66
bb-tools/proguard4.7/src/proguard/retrace/ReTrace.java on lines 659..666
bb-tools/proguard4.7/src/proguard/util/VariableStringMatcher.java on lines 38..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status